Hi Chali,

Thanks for your patch.

On 7/25/25 06:31, chalian...@gmail.com wrote:
> From: Chali Anis <chalian...@gmail.com>
> 
> Fixes: fd940ff6512b ("pinctrl: tegra30: parse drive groups")
> Signed-off-by: Chali Anis <chalian...@gmail.com>

Reviewed-by: Ahmad Fatoum <a.fat...@pengutronix.de>

Cheers,
Ahmad

> ---
>  drivers/pinctrl/pinctrl-tegra30.c | 10 +++++-----
>  1 file changed, 5 insertions(+), 5 deletions(-)
> 
> diff --git a/drivers/pinctrl/pinctrl-tegra30.c 
> b/drivers/pinctrl/pinctrl-tegra30.c
> index f706ae6bfdfd..c542dee96ff2 100644
> --- a/drivers/pinctrl/pinctrl-tegra30.c
> +++ b/drivers/pinctrl/pinctrl-tegra30.c
> @@ -669,31 +669,31 @@ static int pinctrl_tegra30_set_drvstate(struct 
> pinctrl_tegra30 *ctrl,
>       if (schmitt >= 0) {
>               val = readl(regaddr);
>               val &= ~(0x1 << group->schmitt_bit);
> -             val |= hsm << group->schmitt_bit;
> +             val |= schmitt << group->schmitt_bit;
>               writel(val, regaddr);
>       }
>       if (pds >= 0) {
>               val = readl(regaddr);
>               val &= ~(((1 << group->drvdn_width) - 1) << group->drvdn_bit);
> -             val |= hsm << group->drvdn_bit;
> +             val |= pds << group->drvdn_bit;
>               writel(val, regaddr);
>       }
>       if (pus >= 0) {
>               val = readl(regaddr);
>               val &= ~(((1 << group->drvup_width) - 1) << group->drvup_bit);
> -             val |= hsm << group->drvup_bit;
> +             val |= pus << group->drvup_bit;
>               writel(val, regaddr);
>       }
>       if (srr >= 0) {
>               val = readl(regaddr);
>               val &= ~(((1 << group->slwr_width) - 1) << group->slwr_bit);
> -             val |= hsm << group->slwr_bit;
> +             val |= srr << group->slwr_bit;
>               writel(val, regaddr);
>       }
>       if (srf >= 0) {
>               val = readl(regaddr);
>               val &= ~(((1 << group->slwf_width) - 1) << group->slwf_bit);
> -             val |= hsm << group->slwf_bit;
> +             val |= srf << group->slwf_bit;
>               writel(val, regaddr);
>       }
>  

-- 
Pengutronix e.K.                  |                             |
Steuerwalder Str. 21              | http://www.pengutronix.de/  |
31137 Hildesheim, Germany         | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686  | Fax:   +49-5121-206917-5555 |


Reply via email to