On 7/17/25 15:14, Bo Sun wrote: > The parameter represents a device tree node, not specifically a bus. > Use more accurate naming following device tree conventions. > > Signed-off-by: Bo Sun <b...@mboxify.com>
Acked-by: Ahmad Fatoum <a.fat...@pengutronix.de> > --- > drivers/of/platform.c | 18 +++++++++--------- > 1 file changed, 9 insertions(+), 9 deletions(-) > > diff --git a/drivers/of/platform.c b/drivers/of/platform.c > index 3600b5f9c1..092ec39b05 100644 > --- a/drivers/of/platform.c > +++ b/drivers/of/platform.c > @@ -399,14 +399,14 @@ static inline struct device > *of_amba_device_create(struct device_node *np) > > /** > * of_platform_bus_create() - Create a device for a node and its children. > - * @bus: device node of the bus to instantiate > + * @node: device node of the bus to instantiate > * @matches: match table for bus nodes > * @parent: parent for new device, or NULL for top level. > * > * Creates a platform_device for the provided device_node, and optionally > * recursively create devices for all the child nodes. > */ > -static int of_platform_bus_create(struct device_node *bus, > +static int of_platform_bus_create(struct device_node *node, > const struct of_device_id *matches, > struct device *parent) > { > @@ -415,22 +415,22 @@ static int of_platform_bus_create(struct device_node > *bus, > int rc = 0; > > /* Make sure it has a compatible property */ > - if (!of_get_property(bus, "compatible", NULL)) { > + if (!of_get_property(node, "compatible", NULL)) { > pr_debug("%s() - skipping %pOF, no compatible prop\n", > - __func__, bus); > + __func__, node); > return 0; > } > > - if (of_device_is_compatible(bus, "arm,primecell")) { > - if (of_amba_device_create(bus)) > + if (of_device_is_compatible(node, "arm,primecell")) { > + if (of_amba_device_create(node)) > return 0; > } > > - dev = of_platform_device_create(bus, parent); > - if (!dev || !of_match_node(matches, bus)) > + dev = of_platform_device_create(node, parent); > + if (!dev || !of_match_node(matches, node)) > return 0; > > - for_each_child_of_node(bus, child) { > + for_each_child_of_node(node, child) { > pr_debug(" create child: %pOF\n", child); > rc = of_platform_bus_create(child, matches, dev); > if (rc) > > -- Pengutronix e.K. | | Steuerwalder Str. 21 | http://www.pengutronix.de/ | 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |