Hi, [adding back barebox mailing list]
On 7/30/25 08:57, anis chali wrote: > Hi Ahmad, > I will check back tomorrow, but I faced the issue when I compiled efi > on arm64 using the clocksource efi will compile the stuff inside the > fixed clock and there is a code using of variant that raised an > undefined reference but maybe it's all good since arm64 support device > trees, so adding the config to enable of tree support will eliminate the > issue. If there is a build error, it should be fixed. I was just wondering how you ran into it. Cheers, Ahmad > > Cheers, > Anis > > > Le mer. 30 juil. 2025, 02:23, Ahmad Fatoum <a.fat...@pengutronix.de > <mailto:a.fat...@pengutronix.de>> a écrit : > > Hi Anis, > > On 30.07.25 05:50, chalian...@gmail.com > <mailto:chalian...@gmail.com> wrote: > > From: Chali Anis <chalian...@gmail.com <mailto:chalian...@gmail.com>> > > > > This permits to not compile when it's not used, fix undefined > > reference error. > > Normally undefined references are garbage collected by the linker if > the code that references them is going to be discarded as well. > > We have configurations with and without OF support that make use > of clocks in CI I think, so I am curious to know what configuration > you used to provoke the error. > > Cheers, > Ahma > > > > > Signed-off-by: Chali Anis <chalian...@gmail.com > <mailto:chalian...@gmail.com>> > > --- > > drivers/clk/clk-fixed-factor.c | 3 +++ > > 1 file changed, 3 insertions(+) > > > > diff --git a/drivers/clk/clk-fixed-factor.c b/drivers/clk/clk- > fixed-factor.c > > index d2c808d40c63..ea04a4bf7f0f 100644 > > --- a/drivers/clk/clk-fixed-factor.c > > +++ b/drivers/clk/clk-fixed-factor.c > > @@ -97,6 +97,8 @@ struct clk_hw > *clk_hw_register_fixed_factor(struct device *dev, > > flags, mult, > div)); > > } > > > > +#ifdef CONFIG_COMMON_CLK_OF_PROVIDER > > + > > /** > > * of_fixed_factor_clk_setup() - Setup function for simple fixed > factor clock > > */ > > @@ -130,3 +132,4 @@ static int of_fixed_factor_clk_setup(struct > device_node *node) > > } > > CLK_OF_DECLARE(fixed_factor_clk, "fixed-factor-clock", > > of_fixed_factor_clk_setup); > > +#endif > > > -- > Pengutronix e.K. | > | > Steuerwalder Str. 21 | http:// > www.pengutronix.de/ <http://www.pengutronix.de/> | > 31137 Hildesheim, Germany | Phone: > +49-5121-206917-0 | > Amtsgericht Hildesheim, HRA 2686 | Fax: > +49-5121-206917-5555 | > -- Pengutronix e.K. | | Steuerwalder Str. 21 | http://www.pengutronix.de/ | 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
