While quite verbose, off-by-one are very annoying, so it makes sense to be very explicit about the expected input. Rename the function in preparation for adding region_overlap_end_exclusive.
Signed-off-by: Ahmad Fatoum <a.fat...@barebox.org> --- commands/iomemport.c | 2 +- common/partitions.c | 6 +++--- include/range.h | 10 +++++----- 3 files changed, 9 insertions(+), 9 deletions(-) diff --git a/commands/iomemport.c b/commands/iomemport.c index bb546e4a3ad9..d7c960d15b41 100644 --- a/commands/iomemport.c +++ b/commands/iomemport.c @@ -21,7 +21,7 @@ static void __print_resources(struct resource *res, int indent, resource_size_t size = resource_size(res); int i; - if (addr && !region_overlap_end(*addr, *addr, res->start, res->end)) + if (addr && !region_overlap_end_inclusive(*addr, *addr, res->start, res->end)) return; if ((flags & FLAG_VERBOSE) && !(flags & FLAG_IOPORT)) diff --git a/common/partitions.c b/common/partitions.c index fdead333a40a..7563cb0e6767 100644 --- a/common/partitions.c +++ b/common/partitions.c @@ -251,9 +251,9 @@ int partition_create(struct partition_desc *pdesc, const char *name, } list_for_each_entry(part, &pdesc->partitions, list) { - if (region_overlap_end(part->first_sec, - part->first_sec + part->size - 1, - lba_start, lba_end)) { + if (region_overlap_end_inclusive(part->first_sec, + part->first_sec + part->size - 1, + lba_start, lba_end)) { pr_err("new partition %llu-%llu overlaps with partition %s (%llu-%llu)\n", lba_start, lba_end, part->name, part->first_sec, part->first_sec + part->size - 1); diff --git a/include/range.h b/include/range.h index 82c152f3f7c8..96e0f124d5d4 100644 --- a/include/range.h +++ b/include/range.h @@ -5,15 +5,15 @@ #include <linux/types.h> /** - * region_overlap_end - check whether a pair of [start, end] ranges overlap + * region_overlap_end_inclusive - check whether a pair of [start, end] ranges overlap * * @starta: start of the first range * @enda: end of the first range (inclusive) * @startb: start of the second range * @endb: end of the second range (inclusive) */ -static inline bool region_overlap_end(u64 starta, u64 enda, - u64 startb, u64 endb) +static inline bool region_overlap_end_inclusive(u64 starta, u64 enda, + u64 startb, u64 endb) { if (enda < startb) return false; @@ -36,8 +36,8 @@ static inline bool region_overlap_size(u64 starta, u64 lena, if (!lena || !lenb) return false; - return region_overlap_end(starta, starta + lena - 1, - startb, startb + lenb - 1); + return region_overlap_end_inclusive(starta, starta + lena - 1, + startb, startb + lenb - 1); } /** -- 2.39.5