iSerialNumber is already added for this device in the line before, so this line is expected to fail. That's a good thing, because str is uninitialized. Let's just drop this superfluous line then.
Signed-off-by: Ahmad Fatoum <a.fat...@barebox.org> --- drivers/usb/core/usb.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/usb/core/usb.c b/drivers/usb/core/usb.c index f59b525f6276..ec487107584c 100644 --- a/drivers/usb/core/usb.c +++ b/drivers/usb/core/usb.c @@ -454,7 +454,6 @@ int usb_new_device(struct usb_device *dev) void *buf; struct usb_host *host = dev->host; struct usb_device *parent = dev->parent; - char str[16]; if (parent) dev_set_name(&dev->dev, "%s-%d", parent->dev.name, @@ -559,7 +558,6 @@ int usb_new_device(struct usb_device *dev) dev->descriptor->iProduct, "%u"); dev_add_param_uint32_fixed(&dev->dev, "iSerialNumber", dev->descriptor->iSerialNumber, "%u"); - dev_add_param_fixed(&dev->dev, "iSerialNumber", str); dev_add_param_fixed(&dev->dev, "Manufacturer", dev->mf); dev_add_param_fixed(&dev->dev, "Product", dev->prod); dev_add_param_fixed(&dev->dev, "SerialNumber", dev->serial); -- 2.39.5