Hi Sascha,
On 25-08-19, Sascha Hauer wrote:
> On Mon, Aug 18, 2025 at 07:26:15PM +0200, Marco Felsch wrote:
...
> > +static int of_overlay_apply_fit(struct device_node *root, struct
> > fit_handle *fit,
> > + struct device_node *config)
> > +{
> > + const char *name = config->name;
> > + struct device_node *overlay;
> > + unsigned long ovl_sz;
> > + const void *ovl;
> > + int ret;
> > +
> > + if (!of_overlay_matches_filter(name, NULL))
> > + return 0;
>
> Can we have a
> pr_debug("FIT config \"%s\" doesn't match filter \"%s\"\n",
> name, of_overlay_filter);
>
> Here?
>
> > +
> > + ret = fit_open_image(fit, config, "fdt", &ovl, &ovl_sz);
> > + if (ret)
> > + return ret;
> > +
> > + overlay = of_unflatten_dtb(ovl, ovl_sz);
>
> if (IS_ERR(overlay))
> ...
>
> > +
> > + if (!of_overlay_matches_filter(NULL, overlay)) {
> > + ret = 0;
> > + goto out;
> > + }
>
> I think a pr_debug printing the reason would be appropriate here as
> well.
Instead of adding it here I adapted the three cases in
of_overlay_matches_filter() which didn't had a pr_debug() yet to cover
all possible cases.
I also added pr_debug("Process FIT config \"%s\"\n", name); at the
beginning of of_overlay_apply_fit().
Regards,
Marco
