On Mon, Sep 15, 2025 at 11:02:12AM +0200, Ahmad Fatoum wrote: > Hi, > > On 9/14/25 9:32 PM, chalian...@gmail.com wrote: > > From: Chali Anis <chalian...@gmail.com> > > > > This patch is an esthetic cleanup, rename the dma_ops to dma_device_ops > > to be sure that the struct in drivers/dma is different from one used in > > arch/riscv/cpu. I accidentally faced the issue telling that the struct is > > defined in the two places but it is not supposed to happen since the > > the driver is never selected from riscv. > > If it's only about resolving the conflicting names, I'd rather rename > dma_ops for RISC-V to dma_map_ops instead.
I thought about this as well, but I actually like using dma_device_ops. We have a struct dma_device, so it's consistent to use a struct dma_device_ops * in there. Sascha -- Pengutronix e.K. | | Steuerwalder Str. 21 | http://www.pengutronix.de/ | 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
