Hi,
On 2025-10-22 12:01, Ahmad Fatoum wrote:
Hi,
On 10/14/25 1:03 PM, Jonas Rebmann wrote:
Introduce a second default encoder that behaves just like barebox_tlv_v1
but uses the "tlv" keyring.
[...]
static struct tlv_decoder barebox_tlv_v1 = {
.magic = TLV_MAGIC_BAREBOX_V1,
.driver.name = "barebox-tlv-v1",
.driver.of_compatible = of_matches,
.mappings = mappings,
+ .signature_keyring = NULL,
I'd drop it given it's explicitly meant as optional parameter.
It is, but I'd like this to be a bit more explicit here. Something has
changed in barebox_tlv_v1 with my patch: It is now to be considered /the
unsinged decoder/ as opposed to barebox_tlv_v1_signed.
+};
+
+static struct tlv_decoder barebox_tlv_v1_signed = {
+ .magic = TLV_MAGIC_BAREBOX_V1_SIGNED,
+ .driver.name = "barebox-tlv-v1-signed",
+ .driver.of_compatible = of_matches_signed,
+ .mappings = mappings,
+ .signature_keyring = "tlv",
};
Regards,
Jonas
--
Pengutronix e.K. | Jonas Rebmann |
Steuerwalder Str. 21 | http://www.pengutronix.de/ |
31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-9 |