If the console input is deactivated through a security policy, then
there is no need to iterate over the current consoles, as none should
have a STDIN.

Signed-off-by: Fabian Pflug <[email protected]>
---
v2:
Fix in console common instead of working around it in startup.c
 common/console_common.c | 6 ++++++
 1 file changed, 6 insertions(+)

diff --git a/common/console_common.c b/common/console_common.c
index 5b7a64c99c..a8319c20f3 100644
--- a/common/console_common.c
+++ b/common/console_common.c
@@ -23,6 +23,7 @@
 #include <linux/math64.h>
 #include <linux/sizes.h>
 #include <linux/overflow.h>
+#include <security/config.h>
 
 #ifndef CONFIG_CONSOLE_NONE
 
@@ -331,6 +332,11 @@ struct console_device *console_get_first_active(void)
 {
        struct console_device *cdev;
        const unsigned char active = CONSOLE_STDIN | CONSOLE_STDOUT;
+
+       /* if no console input is allows, then we can't have STDIN on any. */
+       if (!IS_ALLOWED(SCONFIG_CONSOLE_INPUT))
+               return NULL;
+
        /*
         * Assumption to have BOTH CONSOLE_STDIN AND STDOUT in the
         * same output console
-- 
2.47.3


Reply via email to