Hi Jonas,

On 12/17/25 11:59 AM, Jonas Rebmann wrote:
>> +declare -A repos=(
> 
> Maybe mention that these are the initial commits of the repositories

Done in v2.
> The official upstream for u-boot according to its readme is the gitlab at
> https://source.denx.de/u-boot/u-boot

Denx is no more and the Gitlab has experienced availability problems in
the recent past afair. We can change it later once it has moved to its
new home.

>> +# newest commit that touched this file
>> +file_commit="$(git -C "$repo_root" log -n1 --format=%H -- "$rel_path")"
> 
> So the idea is that the Origin-URL is generated for the commit to which
> <path-to-file> is checked out at the time? Maybe you could state that
> more clearly e.g. in the top of the script or in the usage message.

Done in v2.

> We don't want people to add Origin-URLs referencing just any commit.

Yes, of course, but for me when porting over new code, it's a useful helper.

> Once I get to it, I want to add Origin-URLs to some existing code and
> reconstructing which exact commit something was originally based on is
> the annoying part of that.

I know. This is geared towards new code.

Cheers,
Ahmad

-- 
Pengutronix e.K.                  |                             |
Steuerwalder Str. 21              | http://www.pengutronix.de/  |
31137 Hildesheim, Germany         | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686  | Fax:   +49-5121-206917-5555 |


Reply via email to