Hi Rick, On Sat, Nov 8, 2008 at 10:14 AM, Rick Scott <[EMAIL PROTECTED]> wrote: > On Fri, 2008-11-07 at 21:59 -0500, Chris Frey wrote: >> On Fri, Nov 07, 2008 at 08:04:54PM -0500, Rick Scott wrote: >> > > I grabbed your latest CVS and noticed you added ifdefs. I was still >> > > having >> > > trouble compiling against 2.6.26.5, so I'm moving the crypto stuff into >> > > its own API... I think we only need sha1 right? >> > >> > That's all I know about, so far :) >> >> Me too. :-) >> >> In going through the module, and working on getting it to compile, I >> was wondering what your plans are for it. Are you planning to eventually >> include it in the main kernel? If so, perhaps it is not worth it to >> work so hard to support all possible kernels, and focus should be on >> supporting the latest kernel, and using the kernel coding style guidelines. >> >> - Chris > > Plans? I plan on using it, and learning a little more about the kernel. > I don't want to rule out the possibility of it being in the main kernel. > If it does get to the main kernel, someone else would probably take care > of little changes, like the URB callback stuff. That would be nice :) > With all of the #ifdef's creeping in, I'm thinking of doing some > autoconf macros to spot the differences and using #ifdef HAVE_xxx > instead of having to figure out the correct kernel version for these > things. Should be able to get the info from the headers .... I started > out trying automake, but it was insisting on things that didn't work > with a kernel Makefile :( It should be doable with autoconf though.
Inclusion in main-line should be the target imho. I would also be able to do some reviewing if you like. I'm not that senior in the linux-kernel, but I'm working with usb-drivers too. Instead of working with #ifdef in the main sources for version checking, I would recommend a compatibility header. Only use the new/current kernel funtions, backport/fake them in a header which can be included on the command-line. Same trick does madwifi with compat..h (http://madwifi-project.org/browser/madwifi/trunk/include/compat.h) and 'gcc -include <header> ...'. > In the short term, it _has_ to work with my Fedora Core [34] and CentOS > 5.2 boxes, along with my 8800. I have a 6200, 7100, 8700, and 8800 that > I test with. Oh, and a 6710 which is not relevant for the module but is > my "gold standard" for the serial protocol, along with the rfcomm > bluetooth of the newer devices. Using the same distros here, but I also have the current git-tree of the kernel for compiling against. Please let me know if I can be of any help. (Where are the sources exactly?) Cheers, Niels ------------------------------------------------------------------------- This SF.Net email is sponsored by the Moblin Your Move Developer's challenge Build the coolest Linux based applications with Moblin SDK & win great prizes Grand prize is a trip for two to an Open Source event anywhere in the world http://moblin-contest.org/redirect.php?banner_id=100&url=/ _______________________________________________ Barry-devel mailing list Barry-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/barry-devel
