I agree with this idea too. Either put the message in the status bar, or make the popup window only on top of the Barrybackup window somehow, so it doesn't get disconnected from the application. (I don't know how to do this offhand.
Status bar is probably easier. :-) Maybe if we go the status bar route, we can play a beep or sound to signify completion. Error messages should still get their own popup box, preferably with copy/paste ability to make it easy to report bugs. (Not sure if that is the case right now). - Chris On Tue, Jul 07, 2009 at 09:19:25PM +0800, Ryan Li wrote: > I agree with this, but I don't know what others think? > > Ryan > > Jason Thomas wrote: > > I have a suggestion, the box that pops up when the backup is complete is > > annoying. > > > > I work with multiple work spaces and I start a backup on one, switch to > > another and keep working and the pop up is lost behind other > > applications. > > > > If the status of the backup was in the main window the pop up would not > > be needed. > > > > Thanks. > > > > On Mon, 2009-07-06 at 18:50 -0400, Chris Frey wrote: > > > >> On Fri, Jul 03, 2009 at 10:48:49PM +0800, Ryan Li wrote: > >> > >>> On code level, the main thing I have done is to split the > >>> ScanAndConnect() function into Scan() and Connect(), and remove the > >>> `goto' statement, using a static member as replacement, and Connect() is > >>> triggered only when the value combo box is changed. Also changed the > >>> layout of the window, removed the Fixed widget, making the whole thing > >>> much easier to extend. > >>> > >>> There must be bugs and inconveniences, and I hope to hear your opinions. > >>> > >> I really like this patch, especially making it more modular, breaking > >> up the Scan and Connect functions. Thank you very much! > >> > >> I do have a few complaints before applying: > >> > >> 1) The StatusBarHandler class is a great idea. It should be a > >> standalone class, either BackupWindow.h or its own header. > >> > >> Also I notice that StatusBarHandler gets rid of the call > >> to m_pStatusBar->show_now()... any thoughts on that? > >> > >> 2) All Barry functionality was wrapped in the DeviceInterface > >> class. As such, m_pProbe should not be in BackupWindow, > >> and BackupWindow shouldn't have to do 'new Probe', nor > >> worry about its memory handling. > >> > >> 3) The drop down list should say "No device selected" or > >> "Please select device" if there are multiple devices > >> available. It shouldn't just be empty. Also, if there > >> is only one device available, it should connect to it > >> right away. If you want to make this configurable, that's > >> ok, (default to the old behaviour) but for those who use > >> the GUI a lot, that extra series of clicks just to select > >> their one and only device will get tiring. > >> > >> 4) I don't like the new packed layout. This is a show stopper for me. > >> Everything is packed up tight against the edge of the > >> window, and looks bad. I've attached a screenshot of what > >> the default looks like on my system. > >> > >> > >> On the "future ideas" front (which might be future patches if you like), > >> it might be a good idea for Scan() to clear any existing table entries, so > >> that it can be called repeatedly to refresh the device list. Perhaps on > >> a timer or a button. > >> > >> Also, the better way of handling CheckWorkingDevice() is to enable and > >> disable buttons and menu items based on what is possible given the current > >> state. If no device is selected, the Backup button, for example, should > >> be greyed out. The check you have now is fine, this would just be nice > >> to have. > >> > >> - Chris > >> > >> > >> ------------------------------------------------------------------------------ > >> _______________________________________________ > >> Barry-devel mailing list > >> Barry-devel@lists.sourceforge.net > >> https://lists.sourceforge.net/lists/listinfo/barry-devel > >> > > ------------------------------------------------------------------------------ > Enter the BlackBerry Developer Challenge > This is your chance to win up to $100,000 in prizes! For a limited time, > vendors submitting new applications to BlackBerry App World(TM) will have > the opportunity to enter the BlackBerry Developer Challenge. See full prize > details at: http://p.sf.net/sfu/blackberry > _______________________________________________ > Barry-devel mailing list > Barry-devel@lists.sourceforge.net > https://lists.sourceforge.net/lists/listinfo/barry-devel ------------------------------------------------------------------------------ Enter the BlackBerry Developer Challenge This is your chance to win up to $100,000 in prizes! For a limited time, vendors submitting new applications to BlackBerry App World(TM) will have the opportunity to enter the BlackBerry Developer Challenge. See full prize details at: http://p.sf.net/sfu/blackberry _______________________________________________ Barry-devel mailing list Barry-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/barry-devel
