On Tue, Jul 07, 2009 at 09:18:13PM +0800, Ryan Li wrote: > Yeah, I moved it to BackupWindow.h. First thought was to util.h, but > found that it could only be used in BackupWindow. > I saw that show_now() was not used in some situations, and without it > everything worked fine. Now it's back. :-)
Thanks for the new patches! > I cannot find a good way to display the message in the ComboBox, hence I > put them in the Label. I wonder if there's any way of displaying > messages on a ComboBox when no item is selected? If so, I think the > caption of "(n devices)" would be great. How I've usually done this is to create an unsorted combobox, sort the data myself as I add it, but always add an "item 0" for "None" or "No device selected", etc. The rest of the code has to assume that the first entry in the list is "none". I like the label text update code at the moment. I'd just add a "none" so that it is possible to disable a device without exiting the program. Also, I noticed that the hide() calls are still there, in the error paths. If we had a "none" state, where no device was active, then in the case of a fatal error, such as USB or Barry exception, we could default to "none" and not completely exit the app. > It looked fine under my theme, so I haven't noticed this problem. Now > some padding and spacing are added, it should be better, at least under > the themes I have tested. I really didn't like the new layout again, but this time when I opened it in glade-3, I noticed that the entire window's width was larger. This looked much more pleasing to the eye, in my opinion. I tried playing around with the settings to keep that width in the real application, but it wouldn't work, until I disabled the width request entirely on the main window. I also moved the buttons to the right hand side, like they were, and set a width on the combobox. I've attached a screenshot how it looks here. Can you let me know how it looks on your machine? > >On the "future ideas" front (which might be future patches if you like), > >it might be a good idea for Scan() to clear any existing table entries, so > >that it can be called repeatedly to refresh the device list. Perhaps on > >a timer or a button. > > > Implemented. :-) Excellent. > >Also, the better way of handling CheckWorkingDevice() is to enable and > >disable buttons and menu items based on what is possible given the current > >state. If no device is selected, the Backup button, for example, should > >be greyed out. The check you have now is fine, this would just be nice > >to have. > > Applied, but I kept the CheckWorkingDevice() calls to prevent > unpredictable events. Good idea. I would recommend putting all "set_sensitive" calls in two or more functions, so that it is easy to enable / disable things, and easy to add controls in the future. Maybe EnableDeviceButtons() / DisableDeviceButtons(). All patches so far have been applied, with some fixes. Thanks, - Chris
<<attachment: barrybackup-new-layout.png>>
------------------------------------------------------------------------------ Enter the BlackBerry Developer Challenge This is your chance to win up to $100,000 in prizes! For a limited time, vendors submitting new applications to BlackBerry App World(TM) will have the opportunity to enter the BlackBerry Developer Challenge. See full prize details at: http://p.sf.net/sfu/Challenge
_______________________________________________ Barry-devel mailing list Barry-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/barry-devel
