Hi Hervé,
Thomas DeWeese wrote:
XmlWriter changes right now I'm not going to accept due to some issues:
1) Your updates removed the use of bulk writes which was
specifically added due to performance issues.
Hervé Girod wrote:
Sorry, maybe I first modify this file before this change, and I was a
bit careless and copied / replaced too much code ...
Actually, the need to check if each char >= 0x80 would complicate
the use of bulk writes, so I can understand the removal. I was
more indicating that this was an important feature of the previous
code.
[...] Lots of stuff deleted.
Really annoy bits: ;)
You seem to have been a bit careless with the Copyright lines.
Most of the new classes say 2001, in a few cases you deleted
existing years in a Copyright.
Really I am unlucky and careless !! I picked up a file in Batik SVN
repository at random and I must have accidentally stumbled on classes
which have the old header (I should have checked after, I know...). It
turns out that some of the classes still have the old header. Not a
reason for me to add new ones ;)
Actually the Copyright year(s) should only be updated when the
file is actually modified. So there will be lots of 'old' years
in the Batik repository, since there are sections of code that aren't
updated all the time. In short you need to add 2005 to the Copyright
years list if it already has it, for new files just have 2005.
Finally:
Can I add the 'test' classes to Batik? They have the Apache License
so I assume so but I just wanted to make sure. I will probably
add the WMF viewer to the 'contrib' directory and try and figure
out how to merge the test transcoder into the Batik test framework.
Yes, I put the licence header in those files so you could put it in some
Batik directory if you thought they could be useful.
Ok, thanks!
If you want, I can modify the files according to your remarks and file
the new version of the patch attached to the RFE.
This would be ideal!
---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
