I Thomas,
I modified the files according to your remarks and attached to the RFE
the new patch. Here are some explanations on the modifications :
Thomas DeWeese wrote:
XmlWriter changes right now I'm not going to accept due to some issues:
1) Your updates removed the use of bulk writes which was
specifically added due to performance issues.
2) The change to encode all chars >= 0x80 as hex is not friendly
for foreign language users.... At most this might be made a option
for when writing the document.
=> corrected. I added a parameter in the stream () methods in
SVGGraphics2D to be able to escape characters only if chosen. The
default behavior is "not escaped", so it should not break anything.
SVGGraphics2D
Line 223 in patch:
What's with the null paint stuff? It looks like it isn't used.
=> reverted to Batik reference
Lines 272 & 292 in patch:
I'm not sure that the 'solution' of setting stroke to the
'textColor' is a good one
=> reverted to Batik reference
Line 289:
In what case are we missing setting the font-size correctly?
Is this for cases where you are using 'getRoot' repeatedly?
If so then much more needs to be done I think...
=> reverted to Batik reference
Line 329:
While I appreciate the very good attempt at handling of attributed
Character iterators, I am concerned that the code only considers
the attributes on the first char.
=> I now take care of all the runs and create tspans if needed
(basically, only one text node if only one run, and tspans if there are
more than one run). I take care of the following attributes : Bold,
Italic, Underline, Strikethrough, Foreground, Font, Size, Family (more
than the ones that are needed when transcoding WMF). The new test class
check the behavior with text decorations / AttributedCharacterIterators.
---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
