DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG· RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT <http://issues.apache.org/bugzilla/show_bug.cgi?id=38183>. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND· INSERTED IN THE BUG DATABASE.
http://issues.apache.org/bugzilla/show_bug.cgi?id=38183 ------- Additional Comments From [EMAIL PROTECTED] 2006-02-15 19:22 ------- (In reply to comment #7) > In reply to comment #6) > > Today, it suddenly dawned on me that it would be better if we actually > > started > > to populate XML Graphics Commons with this. After all, FOP now uses the > > codecs > > directly (read and write) and it would be good if we also decoupled these > > Sun-dependent codecs from FOP. So why not just copy the codecs and add the > > ImageWriters to Commons? I think I'll just do that. We have to start at some > > point. :-) > > Well I have this mostly working in my local area. I now have it > passing the Batik regression tests... as long as it still uses the > 'original' readers and writers. In that case, I'll wait with that and move on after you have committed the patch. One day I have to look at the Batik test system. I'm guilty of not running it before I posted the patch. > > Still, the question remains about the placement of the sources. We will > > certainly need a java-1.3 and a java-1.4 directory for the > GraphicsConfiguration > > classes coming from FOP. I think it would be good to place the codecs under > > java-sun-dep (as replacement for the "sources-internal-codec" suggested > > earlier). Thomas, I know you prefer to put everything under one tree but how > > opposed are you to such a (IMO) clean split? > > I don't understand the need to split these sources out... > > What I did in my local repository is created codec/jpeg|png|tiff|jiio > packages and the source for that codec goes in that package. I've > modified the build so that when it can it builds everything (i.e. > on a "sun" JDK 1.4 and higher) Then the services class may reject > some at runtime (like because it can't 'link' the JIIO code under > jdk 1.3). Yes, under Ant this is absolutely no problem. But setting this up in an IDE can be difficult. You can only set include/exclude patterns for source directories in Eclipse since version 3.1. And that means something. It makes the whole thing just much easier for people actually working on Batik. How do you handle this? Do you always compile with the Ant script? I'd freak out because of the performance. > > For those who don't know what XML Graphics Commons is: > > http://wiki.apache.org/xmlgraphics/XmlGraphicsCommonComponents > > Depending on what others think I would like to check in what > I have (preferably to trunk, but I could spin a branch). Since > the jiio stuff still isn't quite right (however it's close) I'd > probably comment them out of the services meta-inf file. > > Even if we move everything to commons this can be easier > once everything is under SVN. > > What do people think? Sounds good. I'll hold off then. It's not like I have no other things I can kill my free/fun time with. :-) -- Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug, or are watching the assignee. --------------------------------------------------------------------- To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
