On Tue, 23 May 2006 18:27:42 +0200
Johannes Berg <[EMAIL PROTECTED]> wrote:
> This doesn't look like PCI-E support to me, and I haven't seen it in
> your earlier patchset.
[1] As Michael said, I just diffed against -rc4 as I saw nobody was testing
the patches. But I didn't care about the fact that this code can't work
with the -rc4 ieee80211 tree. So this patch doesn't work (EIP: [<e198b9d6>]
ieee80211_set_geo+0x17/0x83 [ieee80211] SS:ESP 0068:dd23b99c). For the right
patches, please refer to the patches I previously sent to this list.
> Are you sure we can remove those things for bus type SB? Because, afaik,
> that's how some of the WRT... devices are done. Not sure if we handle
> them that way though. I forgot who created the patch for those, please
> speak up!
[2] I just followed specs. I asked Joe and he told me we never deal with
different bus types. Please take a look at the new specs and correct them
if needed. :)
> > + if (bcm->current_core->id == BCM43xx_COREID_PCI) {
> [...]
> > + } else {
>
> Shouldn't that be an else if .. PCIE? Or is it guaranteed that only
> those ever end up there? I'm not sure.
See [2].
> > /* Set the MAC address in the networking subsystem */
> > - if (is_valid_ether_addr(bcm->sprom.et1macaddr))
> > + if (bcm43xx_current_phy(bcm)->type == BCM43xx_PHYTYPE_A)
> > memcpy(bcm->net_dev->dev_addr, bcm->sprom.et1macaddr, 6);
> > else
> > memcpy(bcm->net_dev->dev_addr, bcm->sprom.il0macaddr, 6);
>
> I thought we wanted to simply try both mac addresses?
See [1].
> > + bcm43xx_geo_init(bcm);
> > +
>
> Again, unrelated change.
See [1].
--
Ciao
Stefano
_______________________________________________
Bcm43xx-dev mailing list
[email protected]
http://lists.berlios.de/mailman/listinfo/bcm43xx-dev
