-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

>> -       if (bcm->chip_rev < 5) {
>> +       if (bcm->core_pci.rev <= 5 && bcm->core_pci.id != 
>> BCM43xx_COREID_PCIE) {
>>                 sbimconfiglow = bcm43xx_read32(bcm, 
>> BCM43xx_CIR_SBIMCONFIGLOW);
>>                 sbimconfiglow &= ~ BCM43xx_SBIMCONFIGLOW_REQUEST_TOUT_MASK;
>>                 sbimconfiglow &= ~ BCM43xx_SBIMCONFIGLOW_SERVICE_TOUT_MASK;
>> -               if (bcm->bustype == BCM43xx_BUSTYPE_PCI)
>> -                       sbimconfiglow |= 0x32;
>> -               else if (bcm->bustype == BCM43xx_BUSTYPE_SB)
>> -                       sbimconfiglow |= 0x53;
>> -               else
>> -                       assert(0);
>> +               sbimconfiglow |= 0x32;
>>                 bcm43xx_write32(bcm, BCM43xx_CIR_SBIMCONFIGLOW, 
>> sbimconfiglow);
>>         }
> 
> Are you sure we can remove those things for bus type SB? Because, afaik,
> that's how some of the WRT... devices are done. Not sure if we handle
> them that way though. I forgot who created the patch for those, please
> speak up!

That was in the original specs.  It was removed in the newer versions,
so I changed the specs to match. afaik, the WRT devices show up as PCI
devices and are not attached via the sb bus.

- -Joe
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.3 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iD8DBQFEdKIowGq7BLLARfoRAqf9AKCj74god4rIBmOkhM8jJrDGM9jF9gCbBlO6
1zAfd8QoS+mdeMoJyVnFVxU=
=zp+U
-----END PGP SIGNATURE-----
_______________________________________________
Bcm43xx-dev mailing list
[email protected]
http://lists.berlios.de/mailman/listinfo/bcm43xx-dev

Reply via email to