On Fri, 2006-07-07 at 00:27 +0200, Martin Langer wrote: > > config FW_LOADER > tristate "Userspace firmware loading support" > + depends on CRYPTO_MD5 > select HOTPLUG
I think that should be select too, since md5 is essentially a library routine. > + u32 ver = 0; The initialisation isn't needed :) > + printk(KERN_INFO PFX "UCODE: %s detection > failure.\n", > + buf); how about just writing 'version unknown' parallel to the 'version a.b.c.d'? And I'd probably create another macro to go from the u32 to the version number, like this: #define PRINT_FW_VERSION(u) (u>>24),(u>>16)&0xff,(u>>8)&0xff,(u)&0xff or such that can then be used in the printk's But that's all minor, looks good to me otherwise johannes
signature.asc
Description: This is a digitally signed message part
