On Fri, Jul 07, 2006 at 12:34:44AM +0200, Johannes Berg wrote: > On Fri, 2006-07-07 at 00:27 +0200, Martin Langer wrote: > > > > config FW_LOADER > > tristate "Userspace firmware loading support" > > + depends on CRYPTO_MD5 > > select HOTPLUG > > I think that should be select too, since md5 is essentially a library > routine.
ok. > > + u32 ver = 0; > > The initialisation isn't needed :) ok. > > + printk(KERN_INFO PFX "UCODE: %s detection > > failure.\n", > > + buf); > > how about just writing 'version unknown' parallel to the 'version a.b.c.d'? It can also be an error case (tfm == NULL). It's not only for unknown versions... > And I'd probably create another macro to go from the u32 to the version > number, like this: > #define PRINT_FW_VERSION(u) (u>>24),(u>>16)&0xff,(u>>8)&0xff,(u)&0xff Yeah. More beauty. Martin _______________________________________________ Bcm43xx-dev mailing list [email protected] http://lists.berlios.de/mailman/listinfo/bcm43xx-dev
