Michael Buesch wrote: > To summerize it. > > We have different kinds of initialization problems in the > bcm43xx-softmac tree on resuming. > These usually don't show up if you suspend to ram. > But if you suspend to disk, you end up completely reloading > the driver through the resume routine. You completely miss > to redo the HW initializations in the attach step, then. > I think you must also redo the coreswitch procedure > to make really sure you start with the correct core. > > And no, it is not correct to just call attach_board from resume. ;) > Instead you must copy (or probably move) the HW init stuff that > is in the attach step to the init step. > > I have done that in my tree in bcm43xx-d80211. > > Not easy to refactor without introducing bugs. Definately _not_ > a patch for next -stable kernel. ;)
After looking through your code, I agree that it is not -stable material. It would be drastic, but we could call remove_one on suspend and init_one on resume. Userland might get excited about the interface disappearing and reappearing, but it should work. Any thoughts? Larry _______________________________________________ Bcm43xx-dev mailing list [email protected] https://lists.berlios.de/mailman/listinfo/bcm43xx-dev
