On Sunday 04 March 2007 19:55, Larry Finger wrote: > As the removal of ethtool capability from bcm43xx has been NACKed, > some useful functionality should be added.
I cannot follow this logics, sorry. ;) > This patch changes it > so that the firmware version is output. I don't see how this is useful. I really want to avoid having more ethtool stuff, as it will only create compatibility issues for the future. This doesn't give information that's not available elsewhere. > #include "bcm43xx.h" > +#include "bcm43xx_main.h" > #include "bcm43xx_ethtool.h" > > #include <linux/netdevice.h> > @@ -42,6 +43,8 @@ static void bcm43xx_get_drvinfo(struct n > strncpy(info->driver, KBUILD_MODNAME, sizeof(info->driver)); > strncpy(info->version, utsname()->release, sizeof(info->version)); > strncpy(info->bus_info, pci_name(bcm->pci_dev), ETHTOOL_BUSINFO_LEN); > + snprintf(info->fw_version, sizeof(info->fw_version), "0x%x", > + bcm43xx_shm_read16(bcm, BCM43xx_SHM_SHARED, > BCM43xx_UCODE_REVISION)); This will crash when the device is not up. -- Greetings Michael. _______________________________________________ Bcm43xx-dev mailing list [email protected] https://lists.berlios.de/mailman/listinfo/bcm43xx-dev
