On Sun, Mar 04, 2007 at 08:02:39PM +0100, Michael Buesch wrote: > On Sunday 04 March 2007 19:55, Larry Finger wrote:
> > @@ -42,6 +43,8 @@ static void bcm43xx_get_drvinfo(struct n > > strncpy(info->driver, KBUILD_MODNAME, sizeof(info->driver)); > > strncpy(info->version, utsname()->release, sizeof(info->version)); > > strncpy(info->bus_info, pci_name(bcm->pci_dev), ETHTOOL_BUSINFO_LEN); > > + snprintf(info->fw_version, sizeof(info->fw_version), "0x%x", > > + bcm43xx_shm_read16(bcm, BCM43xx_SHM_SHARED, > > BCM43xx_UCODE_REVISION)); > > This will crash when the device is not up. Larry, will you be doing a new version of this patch that accounts for this comment? John -- John W. Linville [EMAIL PROTECTED] _______________________________________________ Bcm43xx-dev mailing list [email protected] https://lists.berlios.de/mailman/listinfo/bcm43xx-dev
