Andreas Schwab wrote:
> Larry Finger <[EMAIL PROTECTED]> writes:
> 
>> I have just put a new patch for 2.6.20.2 at
>> ftp://lwfinger.dynalias.org/patches/combined-2.6.20.2.patch. This patch has 
>> some important fixes for
>> 4318 users.

As Andreas noted, the patch is at 
ftp://lwfinger.dynalias.org/combined_2.6.20.2.patch.
> 
> This looks suspicious:
> 
> +     if (phy->connected) {
> +             tmp = bcm43xx_phy_read(bcm, 0x0400) & 0xFF;
> +             if (tmp == 3 || tmp < 6) {
> 
> This is the same as (tmp < 6).
> 
> +                     bcm43xx_phy_write(bcm, 0x04C2, 0x1816);
> +                     bcm43xx_phy_write(bcm, 0x04C3, 0x8006);
> +             }
> +             if (tmp < 6) {
> 
> The original has the (effective) condition (tmp < 6 && tmp != 3).
> 
> +                     bcm43xx_phy_write(bcm, 0x04CC,
> +                                       (bcm43xx_phy_read(bcm, 0x04CC)
> +                                        & 0x00FF) | 0x1F00);
>               }

Somehow, an intermediate patch of mine was inadvertently added. The patch file 
has been updated to
have the correct material, and now looks like my version of wireless-2.6.

Thanks for spotting my mistake.

Larry

_______________________________________________
Bcm43xx-dev mailing list
[email protected]
https://lists.berlios.de/mailman/listinfo/bcm43xx-dev

Reply via email to