Sorry it has taken so long to answer, but I am traveling.
Michael Buesch wrote:
> On Thursday 29 November 2007 00:48:40 Larry Finger wrote:
>
>> @@ -2802,6 +2800,13 @@ static int b43_op_config(struct ieee8021
>> out_unlock_mutex:
>> mutex_unlock(&wl->mutex);
>>
>> + /* if a LED is devoted to the radio and the switch is on, send
>> + * KEY_WLAN press/release keystrokes */
>> + if (!err && dev->radio_hw_enable && &dev->led_radio) {
> ^^^^^^^^^^^^^^^
> This condition is always true.
It looks to me that the code uses the contents of the LED section of the SPROM
to initialize
dev->led_radio. Can we be certain that the initialization will always be done?
>
>> + input_report_key(rfk->poll_dev->input, KEY_WLAN, 1);
>> + input_report_key(rfk->poll_dev->input, KEY_WLAN, 0);
>> + }
>> +
>
> Anyway, sending a key event here seems pretty bogus. The comment
> doesn't really say anything useful why this is needed.
If a key event (down/up) is not sent, the LED remains off. This location may
not be the best place,
but it is needed someplace, otherwise the switch must be cycled off/on to get
the LED on.
Larry
_______________________________________________
Bcm43xx-dev mailing list
[email protected]
https://lists.berlios.de/mailman/listinfo/bcm43xx-dev
