Hello, Dale!
It would be great if you write in plain text without HTML. It would
make it easier to quote your message.
On Tue, 2008-06-24 at 17:14 -0400, Dale Walsh wrote:
> Since I can't be sure which version I actually have I started with
> what I had with the fix for the subsystem product code and moved
> forward from there.
Please don't do it this way. In general case, it would be dangerous to
integrate your changes in nobody, even you, knows what was changed by
you and what was present in the base code. That's why patches are used
to send code changes.
> Other than adding some checking that seemed to be going on with the
> "sprom_rev 4", (I added similar checking in a couple of places) the
> "sprom_rev 4" is still broken but "sprom_rev 2" appears to now works
> properly.
I understand you are talking about your code, not about my patch?
> case VALUE_ANTGA:
> if (sprom_rev == 4)
> sprom[SPROM4_ANTENNA_GAIN + 2] = (v & 0xFF);
> else
> sprom[SPROM_ANTENNA_GAIN + 2] = (v & 0xFF);
> break;
Do you have any reason to believe that antenna gain for 802.11a is
located there? That's a separate 16-bit register.
> case VALUE_ANTGBG:
> if (sprom_rev == 4)
> sprom[SPROM4_ANTENNA_GAIN + 0] = (v & 0xFF);
> else
> sprom[SPROM_ANTENNA_GAIN + 0] = (v & 0xFF);
> break;
The same question about 802.11bg. Do you actually see any changes if
you modify SPROM?
> case VALUE_ANTGA:
> if (sprom_rev != 4) {
> desc = "A PHY antenna gain";
> offset = SPROM_ANTENNA_GAIN + 1;
> } else {
> desc = "Antenna 1 Gain";
> offset = SPROM4_ANTENNA_GAIN;
> }
> value = sprom[offset + 1];
That's misleading. You are telling users that the data is at offset
0x75, but you are reading it at 0x76.
Your code is consistent, but I don't see any evidence that it's correct.
--
Regards,
Pavel Roskin
_______________________________________________
Bcm43xx-dev mailing list
[email protected]
https://lists.berlios.de/mailman/listinfo/bcm43xx-dev
