Hello!

VALUE_ANTA0, VALUE_ANTA1, VALUE_ANTBG0 and VALUE_ANTBG1 are all read at
SPROM_BOARDREV + 2 for non-rev4 SPROM.  SPROM_BOARDREV + 2 is equal
SPROM_PA0B0, which means that the same data is displayed twice.

The same values are written to SPROM_BOARDREV + 1.  For VALUE_ANTA1,
VALUE_ANTBG0 and VALUE_ANTBG1 there is no special handling for rev4
SPROM, which must be wrong.

Likewise, there is no special treatment for rev4 for VALUE_MAXPA and
VALUE_MAXPBG in modify_value(), but display_value() treats them
separately.

It seems to me that ssb-sprom should be rewritten.  I think the SPROM
structure should be described as a table for every SPROM revision in a
format like this:

ID, name, byte offset, bit offset, bit size

That should solve the problem of synchronization between read and write
functions. 

-- 
Regards,
Pavel Roskin
_______________________________________________
Bcm43xx-dev mailing list
[email protected]
https://lists.berlios.de/mailman/listinfo/bcm43xx-dev

Reply via email to