Pavel Roskin wrote: > Hello! > > VALUE_ANTA0, VALUE_ANTA1, VALUE_ANTBG0 and VALUE_ANTBG1 are all read at > SPROM_BOARDREV + 2 for non-rev4 SPROM. SPROM_BOARDREV + 2 is equal > SPROM_PA0B0, which means that the same data is displayed twice. > > The same values are written to SPROM_BOARDREV + 1. For VALUE_ANTA1, > VALUE_ANTBG0 and VALUE_ANTBG1 there is no special handling for rev4 > SPROM, which must be wrong. > > Likewise, there is no special treatment for rev4 for VALUE_MAXPA and > VALUE_MAXPBG in modify_value(), but display_value() treats them > separately. > > It seems to me that ssb-sprom should be rewritten. I think the SPROM > structure should be described as a table for every SPROM revision in a > format like this: > > ID, name, byte offset, bit offset, bit size > > That should solve the problem of synchronization between read and write > functions.
I plead guilty to messing up the rev 4 stuff. I agree that ssb-sprom should be rewritten; however, before that is done, we need to think carefully as to what variables should be exposed for a user. For instance, should antenna gains be brought out? What about antenna enable variables? Is there any reason for a user to change these? In addition, it might be useful to know about new revisions. We now have an instance of revision 8, where the only locations that have been identified are the usual ID stuff at the start and the MAC address. Everything else is unknown. What about revs 5, 6 and 7? Larry _______________________________________________ Bcm43xx-dev mailing list [email protected] https://lists.berlios.de/mailman/listinfo/bcm43xx-dev
