Hi Felix, I just want to confirm that when b43 driver set max_rates of ieee80211_hw to be 2, minstrel will think that MRR is not enabled and thus will only provide the best throughput bit rate. There is NO fallback bit rate calculate in this special case.
Also, is it possible to modify the code to support just one-fallback-rate-only case for drivers like b43? I think minstrel should be flexible and provide the fallback rates based on the value of max_rates. Currently, there will be either no fallback rates or 3 fallback rates, right? Feel free to correct me if I am wrong. Thanks, -Bo On Wed, Apr 29, 2009 at 10:57 AM, Michael Buesch <[email protected]> wrote: > On Wednesday 29 April 2009 19:09:33 Bo Han wrote: >> Well, it depends on the interface betweent the device drivers and rate >> control algorithms. Minstrel in the default rate control algorithm in >> the current Linux kernel. It will either set all the 4 bit rates when >> MRR is enabled or only set the best throughput bit rate otherwise. >> That is, there will be either no fallback rate or 3 fallback rates. >> To get 1 fallback rate for b43, I think we need to first enable MRR >> and then select one from the 3 rates. But for the current b43 driver >> code, since MRR is disabled, minstrel will provide no fallback rate. >> Is it clear now? Please correct me if I am wrong. > > Nono, that's not the case. > If it's really the case that mistrel ignores the one-fallback-rate-only > special > case of MRR and doesn't supply a fallback, it's horribly broken and needs to > be fixed. > _Nothing_ needs to be done in the driver in any case. The driver only > supports one > fallback rate. That's written in stone and can't be changed. The RC has to > adapt to that. > Please bug the minstrel maintainer (Felix Fietkau). > > -- > Greetings, Michael. > _______________________________________________ Bcm43xx-dev mailing list [email protected] https://lists.berlios.de/mailman/listinfo/bcm43xx-dev
