On Do, 2009-10-22 at 17:06 -0500, Larry Finger wrote:
> +       static int count;
count is declared, and incremented, but never set to 0. I guess this
will work anyway, because it might be magically cleared to 0 by defining
it (it is static, and will probably be allocated to some place that is
zeroed before), but I'd find it much cleaner if this was declared like
static int count = 0;

>  
>         slot = (int)(&(desc->dma64) - descbase);
>         B43_WARN_ON(!(slot >= 0 && slot < ring->nr_slots));
> @@ -190,6 +191,10 @@ static void op64_fill_descriptor(struct
>         desc->dma64.control1 = cpu_to_le32(ctl1);
>         desc->dma64.address_low = cpu_to_le32(addrlo);
>         desc->dma64.address_high = cpu_to_le32(addrhi);
> +       if (count++ < 10)
> +               b43dbg(ring->dev->wl, "cntrl0, cntrl1, addrlo, addrhi: 0x%X 
> 0x%X"
> +                      " 0x%X 0x%X\n", desc->dma64.control0, 
> desc->dma64.control1,
> +                      desc->dma64.address_low, desc->dma64.address_high);
>  }

_______________________________________________
Bcm43xx-dev mailing list
Bcm43xx-dev@lists.berlios.de
https://lists.berlios.de/mailman/listinfo/bcm43xx-dev

Reply via email to