On 12/28/2009 12:33 PM, Michael Buesch wrote:
> On Monday 28 December 2009 05:49:14 Larry Finger wrote:
>> +                    tmp &= ~(SSB_IMCFGLO_SERTO | SSB_IMCFGLO_REQTO_SHIFT);
> 
> This does not make any sense.
> Did you mean:
> +                     tmp &= ~(SSB_IMCFGLO_SERTO | SSB_IMCFGLO_REQTO);
> 
> 
>> +                    tmp |= 3;
> 
> So you set SER-timeout to 3 and REQ-timeout to 0. Is that what we want?
> REQ=zero smells fishy to me, but if the broadcom code also does this, I'm OK 
> with it.

I did get that wrong. The Broadcom code does the equivalent of

tmp = tmp & ~0x77 | 3

which is what my code ended up doing by accident, but REQ is set to zero.

Are these values discussed anywhere in the open? I have not found anything
regarding the SSB configuration.

Larry
_______________________________________________
Bcm43xx-dev mailing list
Bcm43xx-dev@lists.berlios.de
https://lists.berlios.de/mailman/listinfo/bcm43xx-dev

Reply via email to