W dniu 12 stycznia 2010 23:51 użytkownik Rafał Miłecki
<[email protected]> napisał:
> 2010/1/12 Michael Buesch <[email protected]>:
>> On Tuesday 12 January 2010 20:38:07 Rafał Miłecki wrote:
>>>   struct nphy_txgains { u16 txgm[2]; u16 pga[2]; u16 pad[2]; u16 ipa[2]; };
>>> +struct nphy_iq_est { s32 iq0_prod; u32 i0_pwr; u32 q0_pwr; s32 iq1_prod;
>>> +                     u32 i1_pwr; u32 q1_pwr; };
>>
>> So it seems I didn't notice this earlier, but this violates kernel coding 
>> style.
>> Please do a separate patch that converts all structs from
>> struct foo { a; b; c; };
>> to
>> struct foo {
>>        a;
>>        b;
>>        c;
>> };
>
> OK, will do.

I'll use separated patch to correct old wrong-styled definitions. No
reason to use wrong style when adding new struct with this patch.

-- 
Rafał
_______________________________________________
Bcm43xx-dev mailing list
[email protected]
https://lists.berlios.de/mailman/listinfo/bcm43xx-dev

Reply via email to