On 13/02/19 13:57, Matthijs van Duin wrote:
> Since I just noticed a bunch of people were added to the Cc... Just for
> context, this is the patch set I made to get uio-pruss for the am335x and
> dra7/am57xx working again on the 4.19-ti series kernel:
> https://github.com/mvduin/ti-linux-kernel-dev/tree/ti-linux-4.19.y-uio-pruss/patches/drivers/ti/uio_pruss
>
> Summary of the patches:
> 0001: uio-pruss driver itself
> +#ifdef CONFIG_ARCH_DAVINCI_DA850
> if (pdata->sram_pool) {
> gdev->sram_pool = pdata->sram_pool;
> gdev->sram_vaddr =
What is this sram pool? Is it about MSMC/OCMC RAM? Why is this only for DA850?
> 0002: add missing hwmods for pruss on dra7 (cherry-pick of a commit also
> needed for remoteproc-pru)
This part will eventually be not needed as we are moving away from hwmods.
If you see
https://www.spinics.net/lists/devicetree/msg272572.html
I have got rid of pruss_soc_bus entirely. We now use ti-sysc bus driver to
manage the SYSCONFIG register.
> 0003: add support for ti,deassert-hard-reset (needed for uio-pruss on am335x)
This should also be managed by ti-sysc bus driver but using some form of
reset control driver that can toggle the necessary PRM registers RESET bit.
There were some challenges as to how to keep the clockdomain out of auto-idle
before reset can be issued.
> 0004: outline dts declarations for pruss (can be dropped when full
> declarations are added for remoteproc-pru)
> 0005: dtsi files for enabling uio-pruss (for convenience of #including by
> those who want it)
The only issue I see here is these 2 properties
compatible = "ti,pruss-v2";
ti,pintc-offset = <0x20000>;
It will be nice if we can retain the compatibles that I'm using here
https://lkml.org/lkml/2019/2/4/679
See PRUSS Node->Required properties->compatible
We use a different compatible for every SoC as there are differences e.g.
different RAM sizes, number of interrupts, INTC offset, etc.
So if we can teach uio_pruss to decipher the different compatibles and get the
register offsets/RAM sizes right using some kind
of driver data (of_match_table->data?), then you don't need ti,pintc-offset.
> 0006: enable uio-pruss by default on beagleboard-x15 (feel free to drop, but
> seemed better than nothing until remoteproc-pru works)
>
> On Wed, 13 Feb 2019 at 12:44, Matthijs van Duin <[email protected]
> <mailto:[email protected]>> wrote:
>
> Adding ti,pintc-offset = <0x20000>; to &pruss should suffice
>
>
> Obviously we could also change the uio-pruss driver to avoid this need for
> this property entirely. It ought to be implicit from the compatible-string.
Exactly.
cheers,
-roger
--
Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki.
Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki
--
For more options, visit http://beagleboard.org/discuss
---
You received this message because you are subscribed to the Google Groups
"BeagleBoard" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To view this discussion on the web visit
https://groups.google.com/d/msgid/beagleboard/5C64109F.5020600%40ti.com.
For more options, visit https://groups.google.com/d/optout.
