On 23/07/23 03:58, Eric Altendorf wrote:
That's great! I have pulled the latest code, and it doesn't seem to be
deduplicating the expected items. Let me check my assumptions:
I'm not sure how one is supposed to run multiple importers at once, the
doc kind of only describes running one.
This is a design document, not user documentation. What has been
implemented does not necessarily exactly reflects that design.
Unfortunately the documentation for beangulp is coming along slowly. The
best there is are probably the examples in the package.
So I'm currently running with a Python script that builds a list of
importers, then runs Ingest, as follows; is this correct, or am I
missing some other setup code? >
if __name__ == '__main__':
importers = get_importers()
hooks = []
cli = beangulp.Ingest(importers, hooks).cli
cli()
This looks correct, but you can simplify it a tiny bit: the Ingest
object can be called directly:
ingest = beangump.Ingest(importers, hooks)
ingest()
The deduplication is supposed to run by default, correct?
It should, but I just found that indeed I overlooked some divergence in
the code paths between the time the intra-importer deduplication patches
were written and the time I merged them. As a result, the intra-importer
deduplication is not run. This is what you get when you leave patches
not merged for years. I'm fixing it now.
There seems to be a fairly good default implementation of similarity
comparison, yes?
"fairly good" ?
Hmm, OK, that may work fine, thanks.
"may work fine" ?
These tools have been written to scratch the itch of the persons that
wrote them. If you think that you can find something better elsewhere,
or that you can write something better yourself, you are free to do so.
Just let me know and I'll process a refund for your support contract.
--
You received this message because you are subscribed to the Google Groups
"Beancount" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To view this discussion on the web visit
https://groups.google.com/d/msgid/beancount/a68ccba6-0282-7ef4-b033-e3927be0ffeb%40grinta.net.
