tim-janik commented on this pull request.


> @@ -387,10 +277,6 @@ SoundFontRepoImpl::~SoundFontRepoImpl ()
       delete_fluid_settings (fluid_settings);
       fluid_settings = NULL;

It'd be better to merge the above two lines into `delete_fluid_settings 
(&fluid_settings);` where `delete_fluid_settings` automatically assigns `NULL` 
to the pointer passed in.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/tim-janik/beast/pull/102#pullrequestreview-240010319
_______________________________________________
beast mailing list
[email protected]
https://mail.gnome.org/mailman/listinfo/beast

Reply via email to