Chris Burke wrote: > Chris Burke wrote: > > Sherlock, Ric wrote: > >> The following 2 changes to pacman.ijs enable it to work correctly > >> where > >> J602 is installed to a (Windows OS) directory path > containing spaces: > >> > >> LINE 37 (definition of HTTPCMD & UNZIP) > >> HTTPCMD=: jpath '~install/tools/ftp/wget.exe -O %O -o %L > -t %T %U' > >> becomes > >> HTTPCMD=: '"',(jpath '~install/tools/ftp/wget.exe'),'" > -O %O -o %L > >> -t %T %U' > >> > >> LINE 345 (definition of shellcmd) > >> shell y > >> Becomes > >> shell dquote y > > > > Windows cmd has a peculiar treatment of double quotes, > stripping them > > off unless very strict conditions are met (see cmd /? in a > command window). > > > > Again, I could make the fix, but a fix to shell would be better. I don't know if I agree that it would be better to change shell. As you state above, under some conditions cmd doesn't strip the quotes and I don't know if it would be easy for shell to correctly decide whether or not quotes should be added or not, in all cases. For that reason, I think that shell should pass the string provided by the user with no alterations as it does at the moment.
Whether shell is changed or not, I think the proposed change to HTTPCMD will still be required. Also I note that the fix to shellcmd I proposed would make the use of dquote in LINE 380 of pacman.ijs (definition of unzip) redundant. e=. shellcmd dquote t Becomes e=. shellcmd t ---------------------------------------------------------------------- For information about J forums see http://www.jsoftware.com/forums.htm
