I ran my tests on Win7 and WinXP and everything worked.
I like the addition of the cderx return text.
On 1/24/2011 9:15, bill lam wrote:
> Adding your patch and clean up, getlasterror if return code is
> less than 33.
>
> diff --git a/main/jade/browser.ijs b/main/jade/browser.ijs
> index 7b35c26..4706d8a 100644
> --- a/main/jade/browser.ijs
> +++ b/main/jade/browser.ijs
> @@ -10,7 +10,7 @@ NB. browse
> NB.
> NB. load url/filename in browser
> browse=: 3 : 0
> -cmd=. deb y
> +cmd=. dlb@dtb y
> isURL=. 1 e. '://'&E.
> if. IFJHS do.
> cmd=. '/' (I. cmd='\') } cmd
> @@ -18,7 +18,7 @@ if. IFJHS do.
> if. -.fexist cmd do. EMPTY return. end.
> cmd=. 'file://',cmd
> end.
> - redirecturl_jijxm_=: cmd
> + redirecturl_jijxm_=: (' ';'%20') stringreplace cmd
> EMPTY return.
> end.
> browser=. Browser_j_
> @@ -34,41 +34,31 @@ if. IFWIN do.
> if. 0 = #browser do.
> r=. ShellExecute 0;(uucp 'open');(uucp cmd);NULL;NULL;SW_SHOWNORMAL
> else.
> - r=. ShellExecute 0;(uucp 'open');(uucp browser);(uucp
> cmd);NULL;SW_SHOWNORMAL
> + r=. ShellExecute 0;(uucp 'open');(uucp browser);(uucp dquote
> cmd);NULL;SW_SHOWNORMAL
> end.
> - if. r<33 do. (sminfo 'browse error:',browser,' ',cmd) return. end.
> + if. r<33 do. sminfo 'browse error:',browser,' ',cmd,LF2,1{::cderx'' end.
> EMPTY return.
> end.
> if. 0 = #browser do.
> browser=. dfltbrowser''
> end.
> -if. 0 = IFUNIX +. #browser do.
> - if. -. isURL cmd do.
> - start=. ''
> - else.
> - start=. 'start "" '
> - end.
> - cmd=. 'cmd /C ',start,dquote cmd
> -else.
> - browser=. dquote (browser;Browser_nox_j_){::~ nox=. IFUNIX *. (0;'')
> e.~<2!:5 'DISPLAY'
> - cmd=. '/' (I. cmd='\') } cmd
> - if. -. isURL cmd do.
> - cmd=. 'file://',cmd
> - end.
> - cmd=. browser,' ',dquote cmd
> +browser=. dquote (browser;Browser_nox_j_){::~ nox=. IFUNIX *. (0;'')
> e.~<2!:5 'DISPLAY'
> +cmd=. '/' (I. cmd='\') } cmd
> +if. -. isURL cmd do.
> + cmd=. 'file://',cmd
> end.
> +cmd=. browser,' ',dquote cmd
> try.
> - if. IFUNIX do.
> - 2!:1 cmd, (0=nox)#'&'
> - else.
> - fork_jtask_ cmd
> - end.
> + 2!:1 cmd, (0=nox)#'>/dev/null 2>&1&'
> catch.
> - msg=. 'Could not run the browser with the command:',LF,LF
> - msg=. msg, cmd,LF,LF
> - msg=. msg,'You can change the browser definition in
> Edit|Configure|Base',LF,LF
> + msg=. 'Could not run the browser with the command:',LF2
> + msg=. msg, cmd,LF2
> + if. IFGTK do.
> + msg=. msg, 'You can change the browser definition in
> Edit|Configure|Base',LF2
> + end.
> sminfo 'Run Browser';msg
> end.
> +EMPTY
> )
>
>
----------------------------------------------------------------------
For information about J forums see http://www.jsoftware.com/forums.htm
