> Where will the artwork be stored ? In cache, music folder or somewhere
> else ?

[sb cachefolder]/DownloadedArtwork

> Can I somehow run it on my library without removing all cover.jpg file
> I currently have in the folder of all albums ? I want to make it
> retrieve artwork for all albums just to see how good it works.

Good plan - what I did too. Simplest solution: disable the filter on the query.

Index: Artwork.pm
===================================================================
--- Artwork.pm  (revision 31181)
+++ Artwork.pm  (working copy)
@@ -558,7 +558,7 @@
        # Find distinct albums to check for artwork.
        my $tracks = Slim::Schema->search('Track', {
                'me.audio'   => 1,
-               'me.coverid' => { '='  => undef },
+#              'me.coverid' => { '='  => undef },
        }, {
                'join'     => 'album',
        });


You'd then be able to inspect the downloaded files in the aforementioned 
folder. Unfortunately SBS would still show whatever artwork it did find, not 
only the downloaded. This might require a larger patch (which I haven't tested 
before posting, but I did something similar earlier today):


Index: Artwork.pm
===================================================================
--- Artwork.pm  (revision 31181)
+++ Artwork.pm  (working copy)
@@ -558,7 +558,7 @@
        # Find distinct albums to check for artwork.
        my $tracks = Slim::Schema->search('Track', {
                'me.audio'   => 1,
-               'me.coverid' => { '='  => undef },
+#              'me.coverid' => { '='  => undef },
        }, {
                'join'     => 'album',
        });
@@ -688,6 +688,15 @@
                        
                        else {
                                main::DEBUGLOG && $importlog->is_debug && 
$importlog->debug( "Failed to download artwork for $albumname" );
+
+                               # remove any artwork if nothing has been found
+                               $track->cover( undef );
+                               $track->update;
+
+                               $track->coverid( undef );
+                               $track->update;
+
+                               $track->album->artwork( undef );
                                
                                $cache{"artwork_download_failed_$albumid"} = 1;
                        }

This will basically remove existing artwork data from tracks/albums which were 
not found online.

test.mysb.com seems to be back online...

-- 

Michael
_______________________________________________
beta mailing list
[email protected]
http://lists.slimdevices.com/mailman/listinfo/beta

Reply via email to