Michael, I gave your latest implementation in the "public/feature/extended-browse-modes" a test run, below follows some comments but generally it looks really great.
Some issues/comments from my side after testing it: 1. The "My Music/Album Artists" menu currently only sort items by number so you don't get the "alpha bar" at the top in similar way as you do with the normal "My Music/Artists" menu. The content is sorted alphabetically, it's just the alpha bar that's missing. The same comments also applies to "My Music/Composers" and "My Music/Classical Music by Conductor" menu. 2. I think a "My Music/Classical Music by Composer" would be a better proof of concept than ""My Music/Classical Music by Conductor", the reason being that conductor is usually not the primary browse criteria when browsing by classical music, typically you first select composer or work and then as a second menu level you select conductor. The issue is that WORK isn't supported by the scanner so I think most people will instead tag their classical music with ALBUM tag set to something like "<work> - <conductor>". However, let's not mix WORK tag support into this thread, I'm just suggesting that to make a more usable proof of concept it might be worth to offer a "My Music/Classical Music by Composer" instead of conductor by default. Of course, it can be easily added in the plugin settings page when you have made save work so maybe it's not a big issue. There is a guideline how to tag classical music here to make it fit into the current LMS implementation: http://wiki.slimdevices.com/index.php/Beginners_Guide_To_Classical 3. The "My Music/Album Artists/Various Artists" content currently matches the principle that the scanner would set "album artist=Various Artists" for compilations not explicitly tagged with ALBUMARTIST tag, but as suggested earlier it might be better to have this logic at scanning time instead of executing complex logic when browsing. However, the current content would be the same as the content if album artist was assigned by scanner, so from a functional perspective the current implementation is probably correct (if you ignore people who don't think "Various Artists" should be in the Album Artists browse menu at all unless they have been explicitly tagged with ALBUMARTIST). 4. The plugin settings page seems to have some issue with saving, I can select different options but when I save nothing is saved. Not sure if this might be something with my setup but it works to save other settings. 5. By adding an option to "Filter #2" where I could restrict the menu to a virtual "library" according to the thread I started in the Developers section this would be really really flexible, but this is another discussion. Erland Isaksson ('My homepage' (http://erland.isaksson.info)) (Developer of 'many plugins/applets (both free and commercial)' (http://wiki.slimdevices.com/index.php/User:Erland). If you like to encourage future presence on this forum and/or third party plugin/applet development, 'consider purchasing some plugins' (http://license.isaksson.info)) *Interested in the future of music streaming ? 'ickStream - A world of music at your fingertips' (http://forums.slimdevices.com/showthread.php?98467-Pre-Announcement-ickStream&p=743516)*. ------------------------------------------------------------------------ erland's Profile: http://forums.slimdevices.com/member.php?userid=3124 View this thread: http://forums.slimdevices.com/showthread.php?t=101264 _______________________________________________ beta mailing list [email protected] http://lists.slimdevices.com/mailman/listinfo/beta
