Commit: 3e6ea470ee73159c2b82895396496a79448dfddc Author: Philipp Oeser Date: Wed Jul 14 11:39:38 2021 +0200 Branches: blender-v2.93-release https://developer.blender.org/rB3e6ea470ee73159c2b82895396496a79448dfddc
Fix T89851: Geometry nodes: wrongly detected "Node group has unidentified nodes or sockets" error rBfe22635bf664 introduced a utility to check for this (but it was always returning true). This wasnt a problem in master (since it is unused there), but in the 2.93 branch, this utility is actually used and the error results in all geometry nodetrees to appear with the "Node group has unidentified nodes or sockets" message (and being unusable). Now return false in has_undefined_nodes_or_sockets if all nodes and sockets have been successfully checked. This commit then needs to end up in the 2.93 branch. Maniphest Tasks: T89851 Differential Revision: https://developer.blender.org/D11911 =================================================================== M source/blender/nodes/intern/node_tree_ref.cc =================================================================== diff --git a/source/blender/nodes/intern/node_tree_ref.cc b/source/blender/nodes/intern/node_tree_ref.cc index 49ef1ecf9f7..2b05edef7f3 100644 --- a/source/blender/nodes/intern/node_tree_ref.cc +++ b/source/blender/nodes/intern/node_tree_ref.cc @@ -358,7 +358,7 @@ bool NodeTreeRef::has_undefined_nodes_or_sockets() const return true; } } - return true; + return false; } std::string NodeTreeRef::to_dot() const _______________________________________________ Bf-blender-cvs mailing list [email protected] List details, subscription details or unsubscribe: https://lists.blender.org/mailman/listinfo/bf-blender-cvs
