Hi, The patch has been applied at svn rev50015. Thanks!
On Thu, Aug 16, 2012 at 7:21 PM, Mike Erwin <[email protected]>wrote: > Sergey Sharybin <[email protected]> wrote: > > Made tests and review here. Works cool. From code POV could only see some > > possible cosmetic changes. > > > > Mike, could you see anything bad with the patch? If not -- LGTM. > > No, the patch looks fine to me. (Existing) zoom+orbit is good pretty > much only for object-centered tasks, and overall this is much more > flexible. Thanks, Fredrik! Feel free to commit, Sergey. > Polishing can come later, it's the behavior/UX that matters. > > -- Mike > > > On Wed, Aug 15, 2012 at 9:23 AM, Sergey Sharybin <[email protected] > >wrote: > > > >> Hi, > >> > >> Would check the patch today. > >> > >> > >> On Tue, Aug 14, 2012 at 8:25 PM, Mike Erwin <[email protected] > >wrote: > >> > >>> Awesome! I'll take a look at this after work. The lack of > >>> auto-rotation-pivot (based on what's on screen) made me hesitate to > >>> add free-form pan & rotate before. > >>> > >>> Mike Erwin > >>> musician, naturalist, pixel pusher, hacker extraordinaire > >>> > >>> > >>> On Tue, Aug 14, 2012 at 11:53 AM, Fredrik hansson > >>> <[email protected]> wrote: > >>> > copy pasted from the patch notes: > >>> > i wasn't really happy with how the ndof integration was done so i > made > >>> some changes. > >>> > > >>> > the new behavior of it is that you can rotate and pan the view at the > >>> same time. > >>> > i > >>> > also added a new option to the ndof menu letting you pick > >>> > turntable/trackball independently of the mouse viewport navigation > >>> > style. > >>> > and another option to change the rotation sensitivity separate > >>> > from the panning since the scale of the scene might need you to > change > >>> > the translation speed much higher but the rotation should always work > >>> > the same. > >>> > holding shift + moving the ndof does just as before locking it to > >>> panning > >>> > holding ctrl + moving will lock it to only rotation > >>> > and holding no keys while moving will do both at the same time. > >>> > > >>> > > >>> > > >>> > http://projects.blender.org/tracker/index.php?func=detail&aid=32326&group_id=9&atid=127 > >>> > _______________________________________________ > >>> > Bf-committers mailing list > >>> > [email protected] > >>> > http://lists.blender.org/mailman/listinfo/bf-committers > >>> _______________________________________________ > >>> Bf-committers mailing list > >>> [email protected] > >>> http://lists.blender.org/mailman/listinfo/bf-committers > >>> > >> > >> > >> > >> -- > >> With best regards, Sergey Sharybin > >> > >> > > > > > > -- > > With best regards, Sergey Sharybin > > _______________________________________________ > > Bf-committers mailing list > > [email protected] > > http://lists.blender.org/mailman/listinfo/bf-committers > _______________________________________________ > Bf-committers mailing list > [email protected] > http://lists.blender.org/mailman/listinfo/bf-committers > -- With best regards, Sergey Sharybin _______________________________________________ Bf-committers mailing list [email protected] http://lists.blender.org/mailman/listinfo/bf-committers
