2013/7/1 Campbell Barton <[email protected]>: > I'd prefer WITH_EGL be separate option, it makes it easier if we want > use EGL for non wayland builds later on, > > In CMake you could do this so anyone building doesn't need to set extra > options: > > if(WITH_WAYLAND) > set(WITH_EGL ON) > endif() >
Done: https://github.com/walac/blender-wayland/commit/77a8ef4f574ab1dcf0ed661bd0f3cb255b6fd5b1 > Picky note - would prefer WITH_WAYLAND --> WITH_GHOST_WAYLAND, matches > WITH_GHOST_SDL. > Done: https://github.com/walac/blender-wayland/commit/b61b6432418194bad310ac58fd2cfa2f335df78e > On Tue, Jul 2, 2013 at 9:22 AM, Jason Wilkins <[email protected]> > wrote: >> I wouldn't worry about it yet. I'll just make sure to keep up with any >> updates you provide. >> >> >> On Mon, Jul 1, 2013 at 9:24 AM, Wander Lairson Costa < >> [email protected]> wrote: >> >>> 2013/6/30 Jason Wilkins <[email protected]>: >>> > I'm aware of this now and will keep an eye on it. >>> > >>> > One thing I'm doing is breaking out EGL support so it isn't tied to the >>> > particular platform that is being built for. That shouldn't lead to any >>> > merge conflicts in an entirely new platform like Wayland. It just means >>> > that it would be nice if it moved to use the shared EGL code at some >>> point >>> > later. >>> > >>> >>> Well, I tied EGL to Wayland in cmake, but if there are any EGL switch >>> at merge time, I can change it to when we have WITH_WAYLAND, I switch >>> (something like) WITH_EGL=ON in CMakeLists.txt. >>> >>> If it is preferable, I can separate the two libraries in their own switch. >>> >>> -- >>> Best Regards, >>> Wander Lairson Costa >>> _______________________________________________ >>> Bf-committers mailing list >>> [email protected] >>> http://lists.blender.org/mailman/listinfo/bf-committers >>> >> _______________________________________________ >> Bf-committers mailing list >> [email protected] >> http://lists.blender.org/mailman/listinfo/bf-committers > > > > -- > - Campbell > _______________________________________________ > Bf-committers mailing list > [email protected] > http://lists.blender.org/mailman/listinfo/bf-committers -- Best Regards, Wander Lairson Costa _______________________________________________ Bf-committers mailing list [email protected] http://lists.blender.org/mailman/listinfo/bf-committers
