Is it possible to correct patch application with arcanist to also use the original author? I've been bitten by this before, not acknowledging patch authors properly. If not better make it a rule to also not apply patches through arcanist.
On 21 September 2014 10:05, Sergey Sharybin <[email protected]> wrote: > Campbell, i'm not sure what's up to phabricator here. If you want to know > some data about old patches i can write an exporter for you. For the new > one using neither maniphest nor differencial is gonna to be accurate -- > with all that tendency to commandeer revision the revisions and those devs > who doesn't use use arc to commit and screws things up, leading to need to > abandon the revision instead of marking it as applied, the stats are not > gonna to be accurate. > > We do need to use proper authorship of the git commits, that would solve > hell of a lot parsing issues, which currently sounds just weird to have. > Even more -- it's much cooler when the commit is authored by you instead of > having just "Path by Awesome Guy". > > For this we've got like everything, apart from the email. For this: > > - Phabricator considers this a private information and will show it to > nobody. > - You need to ensure someone is OK to provide his email for the commit. > - You only need to do this once, it's very much likely someone sent some > patch in the past. > - You can you use empty email, by explicitly specifying <>: git commit -a > --author "Awesome Guy <>" -m "Patch adds some real awesome things". > - By you i mean the one who applies the patch. > - Personally i'd just make it a rule to sue proper authorship, it's not mre > difficult than typing "Patch By" anyway. > > And again, if some data from the past is needed to be exported, i'd suggest > exporting it once using php script, putting it as a .py dict and use it by > the script which traverses the git repo to gather contributors. > > > > On Sun, Sep 21, 2014 at 8:27 AM, Harley Acheson <[email protected]> > wrote: > > > Removing the page seems like an extreme reaction. > > > > Why not just keep the page creation as it is right now but then *insert* > > a static html list of the missing 253 names into an "Also Thanks To" > > section until you have this problem sorted out properly? > > > > Cheers, Harley > > _______________________________________________ > > Bf-committers mailing list > > [email protected] > > http://lists.blender.org/mailman/listinfo/bf-committers > > > > > > -- > With best regards, Sergey Sharybin > _______________________________________________ > Bf-committers mailing list > [email protected] > http://lists.blender.org/mailman/listinfo/bf-committers > _______________________________________________ Bf-committers mailing list [email protected] http://lists.blender.org/mailman/listinfo/bf-committers
