Revision: 29757
http://sourceforge.net/p/bibdesk/svn/29757
Author: hofman
Date: 2025-10-26 18:30:26 +0000 (Sun, 26 Oct 2025)
Log Message:
-----------
Np need to implement moveUp: and moveDown: in tableView subclasses
Modified Paths:
--------------
trunk/bibdesk/BDSKOutlineView.h
trunk/bibdesk/BDSKOutlineView.m
trunk/bibdesk/BDSKTableView.h
trunk/bibdesk/BDSKTableView.m
Modified: trunk/bibdesk/BDSKOutlineView.h
===================================================================
--- trunk/bibdesk/BDSKOutlineView.h 2025-10-26 18:20:57 UTC (rev 29756)
+++ trunk/bibdesk/BDSKOutlineView.h 2025-10-26 18:30:26 UTC (rev 29757)
@@ -94,8 +94,6 @@
@property (nonatomic, nullable, strong) NSString *fontNamePreferenceKey;
@property (nonatomic, nullable, strong) NSString *fontSizePreferenceKey;
-- (void)moveUp:(nullable id)sender;
-- (void)moveDown:(nullable id)sender;
- (void)insertNewline:(nullable id)sender;
- (void)insertSpace:(nullable id)sender;
- (void)insertShiftSpace:(nullable id)sender;
Modified: trunk/bibdesk/BDSKOutlineView.m
===================================================================
--- trunk/bibdesk/BDSKOutlineView.m 2025-10-26 18:20:57 UTC (rev 29756)
+++ trunk/bibdesk/BDSKOutlineView.m 2025-10-26 18:30:26 UTC (rev 29757)
@@ -229,51 +229,6 @@
}
}
-- (void)moveUp:(id)sender {
- NSIndexSet *rowIndexes = [self selectedRowIndexes];
- NSUInteger row = [rowIndexes firstIndex];
- if (row == NSNotFound) { // If nothing was selected
- NSUInteger numberOfRows = [self numberOfRows];
- if (numberOfRows > 0) // If there are rows in the table
- row = numberOfRows - 1; // Select the last row
- else
- return; // There are no rows: do nothing
- } else if (row > 0) {
- row--;
- }
-
- if ([self delegate] && [[self delegate]
respondsToSelector:@selector(outlineView:shouldSelectItem:)])
- while ([[self delegate] outlineView:self shouldSelectItem:[self
itemAtRow:row]] == NO)
- if (row-- == 0)
- return; // If we never find a selectable row, don't do
anything
-
- // If the first row was selected, select only the first row. This is
consistent with the behavior of many Apple apps.
- [self selectRowIndexes:[NSIndexSet indexSetWithIndex:row]
byExtendingSelection:NO];
- [self scrollRowToVisible:row];
-}
-
-- (void)moveDown:(id)sender {
- NSIndexSet *rowIndexes = [self selectedRowIndexes];
- NSUInteger row = [rowIndexes lastIndex], numberOfRows = [self
numberOfRows];
- if (row == NSNotFound) { // If nothing was selected
- if (numberOfRows > 0) // If there are rows in the table
- row = 0; // Select the first row
- else
- return; // There are no rows: do nothing
- } else if (row < numberOfRows - 1) {
- ++row;
- }
-
- if ([self delegate] && [[self delegate]
respondsToSelector:@selector(outlineView:shouldSelectItem:)])
- while ([[self delegate] outlineView:self shouldSelectItem:[self
itemAtRow:row]] == NO)
- if (++row > numberOfRows - 1)
- return; // If we never find a selectable row, don't do
anything
-
- // If the first row was selected, select only the first row. This is
consistent with the behavior of many Apple apps.
- [self selectRowIndexes:[NSIndexSet indexSetWithIndex:row]
byExtendingSelection:NO];
- [self scrollRowToVisible:row];
-}
-
- (void)insertNewline:(id)sender {
if ([[self delegate]
respondsToSelector:@selector(outlineViewInsertNewline:)])
[[self delegate] outlineViewInsertNewline:self];
Modified: trunk/bibdesk/BDSKTableView.h
===================================================================
--- trunk/bibdesk/BDSKTableView.h 2025-10-26 18:20:57 UTC (rev 29756)
+++ trunk/bibdesk/BDSKTableView.h 2025-10-26 18:30:26 UTC (rev 29757)
@@ -94,8 +94,6 @@
@property (nonatomic, nullable, strong) NSString *fontSizePreferenceKey;
- (void)invertSelection:(nullable id)sender;
-- (void)moveUp:(nullable id)sender;
-- (void)moveDown:(nullable id)sender;
- (void)insertNewline:(nullable id)sender;
- (void)insertSpace:(nullable id)sender;
- (void)insertShiftSpace:(nullable id)sender;
Modified: trunk/bibdesk/BDSKTableView.m
===================================================================
--- trunk/bibdesk/BDSKTableView.m 2025-10-26 18:20:57 UTC (rev 29756)
+++ trunk/bibdesk/BDSKTableView.m 2025-10-26 18:30:26 UTC (rev 29757)
@@ -203,51 +203,6 @@
}
}
-- (void)moveUp:(id)sender {
- NSIndexSet *rowIndexes = [self selectedRowIndexes];
- NSUInteger row = [rowIndexes firstIndex];
- if (row == NSNotFound) { // If nothing was selected
- NSUInteger numberOfRows = [self numberOfRows];
- if (numberOfRows > 0) // If there are rows in the table
- row = numberOfRows - 1; // Select the last row
- else
- return; // There are no rows: do nothing
- } else if (row > 0) {
- row--;
- }
-
- if ([self delegate] && [[self delegate]
respondsToSelector:@selector(tableView:shouldSelectRow:)])
- while ([[self delegate] tableView:self shouldSelectRow:row] == NO)
- if (row-- == 0)
- return; // If we never find a selectable row, don't do
anything
-
- // If the first row was selected, select only the first row. This is
consistent with the behavior of many Apple apps.
- [self selectRowIndexes:[NSIndexSet indexSetWithIndex:row]
byExtendingSelection:NO];
- [self scrollRowToVisible:row];
-}
-
-- (void)moveDown:(id)sender {
- NSIndexSet *rowIndexes = [self selectedRowIndexes];
- NSUInteger row = [rowIndexes lastIndex], numberOfRows = [self
numberOfRows];
- if (row == NSNotFound) { // If nothing was selected
- if (numberOfRows > 0) // If there are rows in the table
- row = 0; // Select the first row
- else
- return; // There are no rows: do nothing
- } else if (row < numberOfRows - 1) {
- ++row;
- }
-
- if ([self delegate] && [[self delegate]
respondsToSelector:@selector(tableView:shouldSelectRow:)])
- while ([[self delegate] tableView:self shouldSelectRow:row] == NO)
- if (++row > numberOfRows - 1)
- return; // If we never find a selectable row, don't do
anything
-
- // If the first row was selected, select only the first row. This is
consistent with the behavior of many Apple apps.
- [self selectRowIndexes:[NSIndexSet indexSetWithIndex:row]
byExtendingSelection:NO];
- [self scrollRowToVisible:row];
-}
-
- (void)insertNewline:(id)sender {
if ([[self delegate]
respondsToSelector:@selector(tableViewInsertNewline:)])
[[self delegate] tableViewInsertNewline:self];
This was sent by the SourceForge.net collaborative development platform, the
world's largest Open Source development site.
_______________________________________________
Bibdesk-commit mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/bibdesk-commit
