Revision: 29758
http://sourceforge.net/p/bibdesk/svn/29758
Author: hofman
Date: 2025-10-30 10:33:19 +0000 (Thu, 30 Oct 2025)
Log Message:
-----------
allow typing a space when in the middle of type select, don't scroll or
quicklook in this case
Modified Paths:
--------------
trunk/bibdesk/BDSKOutlineView.m
trunk/bibdesk/BDSKTableView.m
trunk/bibdesk/BDSKTypeSelectHelper.h
trunk/bibdesk/BDSKTypeSelectHelper.m
Modified: trunk/bibdesk/BDSKOutlineView.m
===================================================================
--- trunk/bibdesk/BDSKOutlineView.m 2025-10-26 18:30:26 UTC (rev 29757)
+++ trunk/bibdesk/BDSKOutlineView.m 2025-10-30 10:33:19 UTC (rev 29758)
@@ -209,7 +209,7 @@
if ((eventChar == NSEnterCharacter || eventChar == NSFormFeedCharacter
|| eventChar == NSNewlineCharacter || eventChar == NSCarriageReturnCharacter)
&& (modifierFlags & ~NSEventModifierFlagFunction) == 0) {
[self insertNewline:self];
- } else if (eventChar == 0x0020 && modifierFlags == 0) {
+ } else if (eventChar == 0x0020 && modifierFlags == 0 && [typeSelectHelper
isProcessing]) {
[self insertSpace:self];
} else if (eventChar== 0x0020 && modifierFlags ==
NSEventModifierFlagShift) {
[self insertShiftSpace:self];
Modified: trunk/bibdesk/BDSKTableView.m
===================================================================
--- trunk/bibdesk/BDSKTableView.m 2025-10-26 18:30:26 UTC (rev 29757)
+++ trunk/bibdesk/BDSKTableView.m 2025-10-30 10:33:19 UTC (rev 29758)
@@ -183,7 +183,7 @@
[self insertNewline:self];
} else if ((eventChar == NSEnterCharacter || eventChar ==
NSFormFeedCharacter || eventChar == NSNewlineCharacter || eventChar ==
NSCarriageReturnCharacter) && (modifierFlags & ~NSEventModifierFlagFunction) ==
NSEventModifierFlagOption) {
[self insertNewlineIgnoringFieldEditor:self];
- } else if (eventChar == 0x0020 && modifierFlags == 0) {
+ } else if (eventChar == 0x0020 && modifierFlags == 0 && [typeSelectHelper
isProcessing] == NO) {
[self insertSpace:self];
} else if (eventChar== 0x0020 && modifierFlags ==
NSEventModifierFlagShift) {
[self insertShiftSpace:self];
Modified: trunk/bibdesk/BDSKTypeSelectHelper.h
===================================================================
--- trunk/bibdesk/BDSKTypeSelectHelper.h 2025-10-26 18:30:26 UTC (rev
29757)
+++ trunk/bibdesk/BDSKTypeSelectHelper.h 2025-10-30 10:33:19 UTC (rev
29758)
@@ -76,6 +76,8 @@
@property (nonatomic) BOOL cyclesSimilarResults;
@property (nonatomic) BOOL matchesPrefix;
+@property (nonatomic, readonly, getter=isProcessing) BOOL processing;
+
- (void)rebuildTypeSelectSearchCache;
- (BOOL)handleEvent:(NSEvent *)keyEvent;
Modified: trunk/bibdesk/BDSKTypeSelectHelper.m
===================================================================
--- trunk/bibdesk/BDSKTypeSelectHelper.m 2025-10-26 18:30:26 UTC (rev
29757)
+++ trunk/bibdesk/BDSKTypeSelectHelper.m 2025-10-30 10:33:19 UTC (rev
29758)
@@ -64,7 +64,7 @@
@implementation BDSKTypeSelectHelper
-@synthesize delegate, cyclesSimilarResults=cycleResults,
matchesPrefix=matchPrefix;
+@synthesize delegate, cyclesSimilarResults=cycleResults,
matchesPrefix=matchPrefix, processing;
// Init and dealloc
This was sent by the SourceForge.net collaborative development platform, the
world's largest Open Source development site.
_______________________________________________
Bibdesk-commit mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/bibdesk-commit
