Revision: 29923
http://sourceforge.net/p/bibdesk/svn/29923
Author: hofman
Date: 2025-12-01 10:37:30 +0000 (Mon, 01 Dec 2025)
Log Message:
-----------
no need for private setters
Modified Paths:
--------------
trunk/bibdesk/BDSKTypeManager.m
Modified: trunk/bibdesk/BDSKTypeManager.m
===================================================================
--- trunk/bibdesk/BDSKTypeManager.m 2025-12-01 10:11:28 UTC (rev 29922)
+++ trunk/bibdesk/BDSKTypeManager.m 2025-12-01 10:37:30 UTC (rev 29923)
@@ -75,26 +75,7 @@
NSString * const BDSKChangedFieldTypesKey = @"BDSKChangedFieldTypes";
@interface BDSKTypeManager ()
-
- (void)reloadFieldSets;
-
-@property (nonatomic, copy) NSDictionary *fieldsForTypesDict;
-
-@property (nonatomic, copy) NSArray *types;
-
-@property (nonatomic, copy) NSSet *localFileFieldsSet;
-@property (nonatomic, copy) NSSet *remoteURLFieldsSet;
-@property (nonatomic, copy) NSSet *allURLFieldsSet;
-@property (nonatomic, copy) NSSet *personFieldsSet;
-@property (nonatomic, copy) NSSet *booleanFieldsSet;
-@property (nonatomic, copy) NSSet *triStateFieldsSet;
-@property (nonatomic, copy) NSSet *ratingFieldsSet;
-@property (nonatomic, copy) NSSet *integerFieldsSet;
-@property (nonatomic, copy) NSSet *citationFieldsSet;
-@property (nonatomic, copy) NSSet *invalidGroupFieldsSet;
-@property (nonatomic, copy) NSSet *singleValuedGroupFieldsSet;
-@property (nonatomic, copy) NSSet *allFieldsSet;
-
@end
#pragma mark -
@@ -101,7 +82,7 @@
@implementation BDSKTypeManager
-@synthesize fieldsForTypesDict, types, defaultFieldsForTypes, defaultTypes,
localFileFieldsSet, remoteURLFieldsSet, allURLFieldsSet, noteFieldsSet,
numericFieldsSet, titleFieldsSet, containerFieldsSet, personFieldsSet,
booleanFieldsSet, triStateFieldsSet, ratingFieldsSet, integerFieldsSet,
citationFieldsSet, invalidGroupFieldsSet, singleValuedGroupFieldsSet,
allFieldsSet, requiredFieldsForCiteKey, requiredFieldsForLocalFile,
invalidFieldNameCharacterSet=invalidCiteKeyCharSet,
fragileCiteKeyCharacterSet=fragileCiteKeyCharSet;
+@synthesize types, defaultFieldsForTypes, defaultTypes, localFileFieldsSet,
remoteURLFieldsSet, allURLFieldsSet, noteFieldsSet, numericFieldsSet,
titleFieldsSet, containerFieldsSet, personFieldsSet, booleanFieldsSet,
triStateFieldsSet, ratingFieldsSet, integerFieldsSet, citationFieldsSet,
invalidGroupFieldsSet, singleValuedGroupFieldsSet, allFieldsSet,
requiredFieldsForCiteKey, requiredFieldsForLocalFile,
invalidFieldNameCharacterSet=invalidCiteKeyCharSet,
fragileCiteKeyCharacterSet=fragileCiteKeyCharSet;
static BDSKTypeManager *sharedManager = nil;
@@ -226,7 +207,7 @@
[allFields unionSet:citationFieldsSet];
[allFields unionSet:personFieldsSet];
- [self setAllFieldsSet:allFields];
+ allFieldsSet = [allFields copy];
}
@@ -260,19 +241,19 @@
[singleValuedFields unionSet:booleanFields];
[singleValuedFields unionSet:triStateFields];
- [self setLocalFileFieldsSet:localFileFields];
- [self setRemoteURLFieldsSet:remoteURLFields];
- [self setAllURLFieldsSet:allURLFields];
+ localFileFieldsSet = [localFileFields copy];
+ remoteURLFieldsSet = [remoteURLFields copy];
+ allURLFieldsSet = [allURLFields copy];
- [self setRatingFieldsSet:ratingFields];
- [self setTriStateFieldsSet:triStateFields];
- [self setBooleanFieldsSet:booleanFields];
- [self setIntegerFieldsSet:integerFields];
- [self setCitationFieldsSet:citationFields];
- [self setPersonFieldsSet:personFields];
+ ratingFieldsSet = [ratingFields copy];
+ triStateFieldsSet = [triStateFields copy];
+ booleanFieldsSet = [booleanFields copy];
+ integerFieldsSet = [integerFields copy];
+ citationFieldsSet = [citationFields copy];
+ personFieldsSet = [personFields copy];
- [self setInvalidGroupFieldsSet:invalidFields];
- [self setSingleValuedGroupFieldsSet:singleValuedFields];
+ invalidGroupFieldsSet = [invalidFields copy];
+ singleValuedGroupFieldsSet = [singleValuedFields copy];
[self reloadAllFieldNames];
}
@@ -294,8 +275,8 @@
} else {
[data writeToURL:BDSKUserTypeInfoURL() atomically:YES];
- [self setFieldsForTypesDict:newFieldsForTypes];
- [self setTypes:newTypes];
+ fieldsForTypesDict = [newFieldsForTypes copy];
+ types = [newTypes copy];
[self reloadAllFieldNames];
[standardFieldsForTypes removeAllObjects];
This was sent by the SourceForge.net collaborative development platform, the
world's largest Open Source development site.
_______________________________________________
Bibdesk-commit mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/bibdesk-commit
