Revision: 29924
http://sourceforge.net/p/bibdesk/svn/29924
Author: hofman
Date: 2025-12-01 15:29:50 +0000 (Mon, 01 Dec 2025)
Log Message:
-----------
don't use intermediate sets
Modified Paths:
--------------
trunk/bibdesk/BDSKTypeManager.m
Modified: trunk/bibdesk/BDSKTypeManager.m
===================================================================
--- trunk/bibdesk/BDSKTypeManager.m 2025-12-01 10:37:30 UTC (rev 29923)
+++ trunk/bibdesk/BDSKTypeManager.m 2025-12-01 15:29:50 UTC (rev 29924)
@@ -214,21 +214,23 @@
- (void)reloadFieldSets {
NSUserDefaults *sud = [NSUserDefaults standardUserDefaults];
- NSSet *localFileFields = [NSSet setWithArray:[sud
stringArrayForKey:BDSKLocalFileFieldsKey]];
- NSSet *remoteURLFields = [NSSet setWithArray:[sud
stringArrayForKey:BDSKRemoteURLFieldsKey]];
- NSSet *ratingFields = [NSSet setWithArray:[sud
stringArrayForKey:BDSKRatingFieldsKey]];
- NSSet *triStateFields = [NSSet setWithArray:[sud
stringArrayForKey:BDSKTriStateFieldsKey]];
- NSSet *booleanFields = [NSSet setWithArray:[sud
stringArrayForKey:BDSKBooleanFieldsKey]];
- NSSet *citationFields = [NSSet setWithArray:[sud
stringArrayForKey:BDSKCitationFieldsKey]];
- NSSet *personFields = [NSSet setWithArray:[sud
stringArrayForKey:BDSKPersonFieldsKey]];
+ localFileFieldsSet = [NSSet setWithArray:[sud
stringArrayForKey:BDSKLocalFileFieldsKey]];
+ remoteURLFieldsSet = [NSSet setWithArray:[sud
stringArrayForKey:BDSKRemoteURLFieldsKey]];
+ ratingFieldsSet = [NSSet setWithArray:[sud
stringArrayForKey:BDSKRatingFieldsKey]];
+ triStateFieldsSet = [NSSet setWithArray:[sud
stringArrayForKey:BDSKTriStateFieldsKey]];
+ booleanFieldsSet = [NSSet setWithArray:[sud
stringArrayForKey:BDSKBooleanFieldsKey]];
+ citationFieldsSet = [NSSet setWithArray:[sud
stringArrayForKey:BDSKCitationFieldsKey]];
+ personFieldsSet = [NSSet setWithArray:[sud
stringArrayForKey:BDSKPersonFieldsKey]];
- NSMutableSet *allURLFields = [NSMutableSet setWithSet:localFileFields];
- [allURLFields unionSet:remoteURLFields];
+ NSMutableSet *allURLFields = [NSMutableSet setWithSet:localFileFieldsSet];
+ [allURLFields unionSet:remoteURLFieldsSet];
+ allURLFieldsSet = [allURLFields copy];
- NSMutableSet *integerFields = [NSMutableSet setWithSet:ratingFields];
- [integerFields unionSet:triStateFields];
- [integerFields unionSet:booleanFields];
-
+ NSMutableSet *integerFields = [NSMutableSet setWithSet:ratingFieldsSet];
+ [integerFields unionSet:triStateFieldsSet];
+ [integerFields unionSet:booleanFieldsSet];
+ integerFieldsSet = [integerFields copy];
+
NSMutableSet *invalidFields = [NSMutableSet setWithObjects:
BDSKDateModifiedString, BDSKDateAddedString, BDSKDateString,
BDSKTitleString, BDSKContainerString, BDSKChapterString,
@@ -235,24 +237,12 @@
BDSKVolumeString, BDSKNumberString, BDSKPagesString,
BDSKItemNumberString,
BDSKAbstractString, BDSKAnnoteString, BDSKRssDescriptionString,
nil];
[invalidFields unionSet:allURLFields];
+ invalidGroupFieldsSet = [invalidFields copy];
NSMutableSet *singleValuedFields = [NSMutableSet
setWithObjects:BDSKPubTypeString, BDSKTypeString, BDSKCrossrefString,
BDSKJournalString, BDSKBooktitleString, BDSKVolumetitleString,
BDSKSeriesString, BDSKYearString, BDSKMonthString, BDSKPublisherString,
BDSKAddressString, BDSKInstitutionString, BDSKSchoolString,
BDSKOrganizationString, BDSKLocationString, BDSKColorString, nil];
- [singleValuedFields unionSet:ratingFields];
- [singleValuedFields unionSet:booleanFields];
- [singleValuedFields unionSet:triStateFields];
-
- localFileFieldsSet = [localFileFields copy];
- remoteURLFieldsSet = [remoteURLFields copy];
- allURLFieldsSet = [allURLFields copy];
-
- ratingFieldsSet = [ratingFields copy];
- triStateFieldsSet = [triStateFields copy];
- booleanFieldsSet = [booleanFields copy];
- integerFieldsSet = [integerFields copy];
- citationFieldsSet = [citationFields copy];
- personFieldsSet = [personFields copy];
-
- invalidGroupFieldsSet = [invalidFields copy];
+ [singleValuedFields unionSet:ratingFieldsSet];
+ [singleValuedFields unionSet:booleanFieldsSet];
+ [singleValuedFields unionSet:triStateFieldsSet];
singleValuedGroupFieldsSet = [singleValuedFields copy];
[self reloadAllFieldNames];
This was sent by the SourceForge.net collaborative development platform, the
world's largest Open Source development site.
_______________________________________________
Bibdesk-commit mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/bibdesk-commit
