On 7 Mar 2008, at 8:01 PM, Adam R. Maxwell wrote:
In article <[EMAIL PROTECTED]>, Christiaan Hofman <[EMAIL PROTECTED]> wrote:On 7 Mar 2008, at 7:16 PM, Adam Maxwell wrote:Forgot to say: the new UI stuff on the trunk looks good. Nice work onit!Well, it's mostly tweaking your stuff. Be aware that I found 2 bugs in your changes: - you did not open/close the slider window (which leads to drawing artifacts and childwindow problems).I had more problems with the child window when calling orderOut: on theslider window,
You need to call orderOut: at the end of the animation, so you need to use a custom animator and use the delegate method. I've implemented all of that now in FVSliderWindow, so the FileView doesn't need to bother.
so decided it wasn't necessary since the alpha is set to zero. What artifacts did you see?
<<inline: slider.png>>
This happens when you resize the fileview after you have at least once shown the slider. Also adding/removing child windows when they're not properly shown/removed can lead to weird effects. E.g. if you close a child window without removing it first, the parent window gets hidden. Similarly, adding a child window that is not yet moved onscreen can get the window server confused. Also, I think it is wrong to keep the window around with alpha=0.
- an unmatched lock in FVWebIcon, when it failed.thanks, I'll look at that.
------------------------------------------------------------------------- This SF.net email is sponsored by: Microsoft Defy all challenges. Microsoft(R) Visual Studio 2008. http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/
_______________________________________________ Bibdesk-develop mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/bibdesk-develop
