Kevin's fix is already pushed to the latest bioc release and devel.
Thanks,
Mike
On 04/10/2014 11:44 PM, bioc-devel-requ...@r-project.org wrote:
> Subject:
> Re: [Bioc-devel] Dependency on windowing systems in the flowCore package
> From:
> Kieran O'Neill <kone...@bccrc.ca>
> Date:
> 04/10/2014 05:20 PM
>
> To:
> Kevin Ushey <kevinus...@gmail.com>
> CC:
> "bioc-devel@r-project.org" <bioc-devel@r-project.org>
>
>
> Thanks Kevin!
>
> That would have been my proposed option 3 if I had realised it would be
> that simple.
>
> This will make my (and several other analysts I know's) lives a lot easier!
>
> Cheers,
> Kieran
>
>
>
>
> On 10 April 2014 16:11, Kevin Ushey<kevinus...@gmail.com> wrote:
>
>> >Hi Kieran,
>> >
>> >I've kickstarted the process by sending a pull request here:
>> >https://github.com/RGLab/flowCore/pull/21
>> >
>> >Thanks,
>> >Kevin
>> >
>> >
>> >On Thu, Apr 10, 2014 at 3:48 PM, Kasper Daniel Hansen <
>> >kasperdanielhan...@gmail.com> wrote:
>> >
>>> >>My 2ct is that it is worthwhile to have a lean core package. It sounds
>>> >>like it would be trivial to separate gating into a new package, and -
>>> >>provided functions are not renamed - would be trivial for downstream
>>> >>packages to adapt to.
>>> >>
>>> >>Especially in situations where competing groups work on the same analysis
>>> >>domain, it is great if they can agree on basic data representation, and
>>> >>that chance is increased (IMO) if the core package does not include too
>>> >>much analysis tools.
>>> >>
>>> >>Best,
>>> >>Kasper
>>> >>
>>> >>
>>> >>On Thu, Apr 10, 2014 at 6:35 PM, Kevin Ushey<kevinus...@gmail.com>wrote:
>>> >>
>>>> >>>Hi Kieran, Dan,
>>>> >>>
>>>> >>>I would suggest that you open an issue at
>>>> >>>https://github.com/RGLab/flowCore/issues/new.
>>>> >>>
>>>> >>>Perhaps the easiest solution is to copy featureSignif from feature into
>>>> >>>flowCore (giving adequate citation and such, respecting licenses...). It
>>>> >>>looks like the function doesn't depend too much on other functionality
>>>> >>>in
>>>> >>>the feature package, so this shouldn't be too much of a problem.
>>>> >>>
>>>> >>>Thanks,
>>>> >>>Kevin
[[alternative HTML version deleted]]
_______________________________________________
Bioc-devel@r-project.org mailing list
https://stat.ethz.ch/mailman/listinfo/bioc-devel
