Hi Nitesh, In my local RELEASE_1_3, I plan to do the following:
* Git rest –hard <commit_id> * Change the version number (add 1 to the current z) * Git Commit (locally) * Git push upstream RELEASE_3_11 Is this acceptable? Thanks, Fathi From: Nitesh Turaga <nturaga.b...@gmail.com> Date: Friday, August 21, 2020 at 12:50 PM To: "Elloumi, Fathi (NIH/NCI) [C]" <fathi.ello...@nih.gov> Cc: bioc-devel <bioc-devel@r-project.org> Subject: Re: About rcellminerData and rcellminerData new versions Hi, This is not ideal. We do not reset packages to previous versions. Please make the changes and “only” increment the version number in the “patch” version i.e x.y.z version number, update the “z”. Best, Nitesh On Aug 21, 2020, at 12:47 PM, Elloumi, Fathi (NIH/NCI) [C] <fathi.ello...@nih.gov<mailto:fathi.ello...@nih.gov>> wrote: Thanks Nitesh for you prompt response. Dear Bioconductor team, Could please help reset the two packages rcellminer and rcellminerData to a previous commit done on April the 27th (I think version 2.10.0). Thanks, Fathi From: Nitesh Turaga <nturaga.b...@gmail.com<mailto:nturaga.b...@gmail.com>> Date: Friday, August 21, 2020 at 12:39 PM To: "Elloumi, Fathi (NIH/NCI) [C]" <fathi.ello...@nih.gov<mailto:fathi.ello...@nih.gov>> Cc: "Van Twisk, Daniel" <daniel.vantw...@roswellpark.org<mailto:daniel.vantw...@roswellpark.org>>, Hervé Pagès <hpa...@fredhutch.org<mailto:hpa...@fredhutch.org>>, Nitesh Turaga <nitesh.tur...@gmail.com<mailto:nitesh.tur...@gmail.com>>, bioc-devel <bioc-devel@r-project.org<mailto:bioc-devel@r-project.org>> Subject: Re: About rcellminerData and rcellminerData new versions Hi, It is an enhancement. Only bug fixes should go into RELEASE_3_11. The devel branch is the “master” branch in git, there is no RELEASE_3_12 yet. We will create it in the next release. Push your changes to the “master” branch. Address your emails to bioc-devel@r-project.org<mailto:bioc-devel@r-project.org>. Nitesh On Aug 21, 2020, at 12:34 PM, Elloumi, Fathi (NIH/NCI) [C] <fathi.ello...@nih.gov<mailto:fathi.ello...@nih.gov>> wrote: Dear Bioconductor team, As mentioned in my previous email (please see below), do you consider adding and cleaning data an enhancement should be only included in the develop branch and NOT in the current release (3_11) branch version but in the new release 3_12? I followed the instructions at https://bioconductor.org/developers/how-to/git/sync-existing-repositories/<https://secure-web.cisco.com/1wzo1Tbjitl2EN1_GywseAoblHfVez1mpR_8vtKAOR5f0SO5CK8EMPzf8lWYBMwUWDdtVm2grbA7V-FkME7sCxvoM2zAWl4-mKDEVlEBfIUHGG-fKAlYcFyWx5bbHmwP1WZPfm0pV8GFVSuNiWC3uoBSC5-Cn3tupqwknT4r6LZTSWEg0apO9OSaqMbuxDNVA9LhQg_2jkq5BkR6lvEglfR6jT7g7PGZBCto81NotT2sZ4fhV2ebLzDk17p6MMW0tk3NiwkA__fQoJg8zwhAoL4y9mygXWwFtJWtvNCth-SmXGKPmrDO9hDeUWsJeW3fJtGNCcVvHerOGfis4AvhRQ8Qu9-PVlnfShavxSk8gnL4/https%3A%2F%2Fbioconductor.org%2Fdevelopers%2Fhow-to%2Fgit%2Fsync-existing-repositories%2F> with instruction to update on both devel and release branches. Please advise. Best, Fathi From: "Elloumi, Fathi (NIH/NCI) [C]" <fathi.ello...@nih.gov<mailto:fathi.ello...@nih.gov>> Date: Friday, August 21, 2020 at 10:51 AM To: "Van Twisk, Daniel" <daniel.vantw...@roswellpark.org<mailto:daniel.vantw...@roswellpark.org>> Subject: About rcellminerData and rcellminerData new versions Dear Daniel, This week I pushed new version (2.10.2) for both packages rcellminer and rcellminerData in the release_3_11 adding new drug data and cleaning some “bad” experiments. Do you consider this against your policy here below. From the Bioconductor paper in 2004 (https://genomebiology.biomedcentral.com/articles/10.1186/gb-2004-5-10-r80<https://secure-web.cisco.com/1VIGZ7EAtIYsfu6Ca661xpkH3USe0M_NVD2dMnpqmIJ-zLYogJiX-cBH9RcpX52D-aC7BLB6FzOEn03TBiMT0pAvlhYMIBhC18-gtN9awFCHYIH3V15aqi49y7yXs-HsjyOe7ybNZVC53ZCqKbOdtIRR773n2VId06RB6IAVxHuk_hhgVIu-4E4ISA5vNuqH3u352mqCz22_nYduC4PpyCSle6oXb5Tn1j0TWVa3Sm9g7xuBa2K8Mr6Nej9LEuMaeGGefdD08Ty8HlFxk3ozUp0K5ykcKsbsddKmN4aZkcz5qGfIIH81qRBv1wx0CQTavgHihm3S-z5BRj7nDFHkHBQ/https%3A%2F%2Fgenomebiology.biomedcentral.com%2Farticles%2F10.1186%2Fgb-2004-5-10-r80>): The only changes allowed to be made on the release version are bug fixes and documentation improvements. This ensures that users will not encounter radical new behaviors in code obtained in the release version. All other changes such as enhancements or design changes are carried out on the development branch [34]. Please let me know asap and if needed we will back to previous commit. Thanks, -- Fathi Fathi Elloumi, PhD Sr. Bioinformatics Software Engineer Contractor GDIT Inc Developmental Therapeutics Branch NIH/NCI/CCR Phone: 240-760-6601 [[alternative HTML version deleted]] _______________________________________________ Bioc-devel@r-project.org mailing list https://stat.ethz.ch/mailman/listinfo/bioc-devel
